Page MenuHomePhabricator
Differential D1228

Add support for SPLIT opcodes
ClosedPublic
Actions

Authored by deadalnix on Mar 30 2018, 14:42.

Details

Reviewers
movrcx
jasonbcox
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Maniphest Tasks
T308: Adds OP_SPLIT functionality into interpreter.cpp
Commits
rSTAGINGa39b04fae804: Add support for SPLIT opcodes
rABCa39b04fae804: Add support for SPLIT opcodes
Summary

Add handling for SPLIT opcodes when the monolith script flag is enabled.

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
opcodesplit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2207
Build 2558: Bitcoin ABC Buildbot (legacy)
Build 2557: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 30 2018, 14:42
teamcity added a comment.Mar 30 2018, 14:44

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2206: Diff 3341.Mar 30 2018, 15:03
teamcity added a comment.Mar 30 2018, 15:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jasonbcox requested changes to this revision.Mar 30 2018, 16:00
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/script/interpreter.cpp
1279 ↗(On Diff #3341)

Rename size -> position to be inline with the comment for OP_SPLIT

src/test/data/script_tests.json
869 ↗(On Diff #3341)

Does this really return SPLIT_RANGE? I'm not seeing this in the implementation. If it does somehow, i think this error should be captured more explicitly when position is read off the stack.

src/test/monolith_opcodes.cpp
411 ↗(On Diff #3341)

Add a test for negative position value

This revision now requires changes to proceed.Mar 30 2018, 16:00
deadalnix added inline comments.Mar 30 2018, 16:12
src/test/data/script_tests.json
869 ↗(On Diff #3341)

-1 is a very large value when considered as unsigned.

deadalnix updated this revision to Diff 3343.Mar 30 2018, 16:12

Add C++ test case for negative value and rename size to position.

teamcity added a comment.Mar 30 2018, 16:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

jasonbcox accepted this revision.Mar 30 2018, 16:30
This revision is now accepted and ready to land.Mar 30 2018, 16:30
teamcity added a comment.Mar 30 2018, 16:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 30 2018, 16:56

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2207: Diff 3343.Mar 30 2018, 16:56
Closed by commit rABCa39b04fae804: Add support for SPLIT opcodes (authored by movrcx, committed by deadalnix). · Explain WhyMar 30 2018, 17:36
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
script/
29 lines
1 line
2 lines
test/
data/
33 lines
34 lines
1 line

Diff 3343

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script_error.h

Loading...
View Options

src/script/script_error.cpp

Loading...
View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/monolith_opcodes.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...