Page MenuHomePhabricator

[website] Add division tags to eCash page
ClosedPublic

Authored by Mengerian on May 5 2022, 18:15.

Details

Reviewers
Fabien
aimal
Group Reviewers
Restricted Project
Commits
rABCWEBe3d26cfd6b3f: [website] Add division tags to eCash page
Summary

Allow people to link directly to topics, such as https://bitcoinabc.org/ecash/#mining

Test Plan

Tested running locally with urls such as http://127.0.0.1:4000/ecash/#mining

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
ecash-section-tags
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19001
Build 37761: arc lint + arc unit

Event Timeline

Note: I'm not too familiar with how CSS works. I did something that seems to work, and looks fine on the web page, but seems kinda hacky. Open so suggestions on that part.

Fabien requested changes to this revision.May 6 2022, 11:19
Fabien added a subscriber: Fabien.
Fabien added inline comments.
css/main.css
732 ↗(On Diff #33418)

you can as well keep the ecashpage div and avoir copying this for each id (or make it a class)

This revision now requires changes to proceed.May 6 2022, 11:19

Use a CSS class to preserve formatting

Fabien requested changes to this revision.May 10 2022, 20:44
Fabien added inline comments.
ecash.html
45 ↗(On Diff #33463)

What this really does is applying the text-center property to the h2 title, since there is no text in these sections.
If this is what you want, then this class:

  1. Should apply to the title
  2. Should have a more relevant name
211 ↗(On Diff #33463)

You don't need the class here, it's already within an ecash-section

This revision now requires changes to proceed.May 10 2022, 20:44
aimal signed these changes with MFA.May 11 2022, 01:16
aimal requested changes to this revision.
aimal added a subscriber: aimal.

Since the website uses Bootstrap, no need to use custom CSS. A better approach is to just use the built-in text centering Bootstrap class:

<div id="info" class="text-center">

Remove all CSS changes except adding the ID tags

Will fix the CSS in other Diffs

ecash.html
46 ↗(On Diff #33482)

What about statistics instead ? Also (unrelated) we should add ecash.coin.dance to this list

Rename "statistics" to "market"

Will remove Blockchair in a subsequent Diff (they are repeated below in the "Exchanges" section)

This revision is now accepted and ready to land.May 12 2022, 03:32