[README] Updated comments on stacked diff procedure
ClosedPublic
Actions

Authored by bytesofman on Jun 8 2022, 17:59.

Details

Reviewers

emack
sdulfari

Group Reviewers

Restricted Project

Commits

rABCaa031798feee: [README] Updated comments on stacked diff procedure

Summary

Update CONTRIBUTING.md to reflect current procedure for stacked diffs

I went through the blog posts and hit these roadblocks.

Test Plan

Confirm the comments are legible & make sense.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

stacked-diff-procedure-update

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19313
Build 38365: Build Diff
Build 38364: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 8 2022, 17:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2022, 17:59

bytesofman requested review of this revision.Jun 8 2022, 17:59

Harbormaster completed remote builds in B19313: Diff 33904.Jun 8 2022, 17:59

emack accepted this revision.Jun 8 2022, 20:54

This revision is now accepted and ready to land.Jun 8 2022, 20:54

sdulfari accepted this revision.Jun 8 2022, 22:36

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

CONTRIBUTING.md
229	Some nits: In `...last part of your stacked diff...` changing "last part" to "latest commit" is slightly clearer. 80 character paragraph width

Closed by commit rABCaa031798feee: [README] Updated comments on stacked diff procedure (authored by bytesofman). · Explain WhyJun 8 2022, 22:44

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCaa031798feee: [README] Updated comments on stacked diff procedure.

Fabien mentioned this in D11625: [LINT] Fix trailing whitespaces in the contributing doc.Jun 14 2022, 09:45

Fabien mentioned this in rABCdd53a8691801: [LINT] Fix trailing whitespaces in the contributing doc.Jun 14 2022, 11:51

Revision Contents
Changeset List

Path

Size

CONTRIBUTING.md

4 lines

Diff 33904

View Options

[README] Updated comments on stacked diff procedureClosedPublicActions