Page MenuHomePhabricator
Differential D1247

Refactor wallet tests as built by cmake
ClosedPublic
Actions

Authored by deadalnix on Apr 5 2018, 14:01.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe5949decf457: Refactor wallet tests as built by cmake
rABCe5949decf457: Refactor wallet tests as built by cmake
Summary

The previous build would add them as a library, but this actually do not work as the test get pruned by the linker before boost has the opportunity to do anything with them. Now the test are directly built in the test_bitcoin executable.

Test Plan
ninja
./src/test/test_bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmakewallettest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2240
Build 2623: Bitcoin ABC Buildbot (legacy)
Build 2622: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 5 2018, 14:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2018, 14:01
teamcity added a subscriber: teamcity.Apr 5 2018, 14:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix added parent revisions: D1245: Add support for scheduler_tests in cmake, D1246: Remove reclarations of read_json, create a dedicated header instead.Apr 5 2018, 14:02
teamcity added a comment.Apr 5 2018, 14:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2240: Diff 3394.Apr 5 2018, 14:20
jasonbcox accepted this revision.Apr 5 2018, 19:08
jasonbcox added a subscriber: jasonbcox.

Please change bosst -> boost in the diff summary.

This revision is now accepted and ready to land.Apr 5 2018, 19:08
deadalnix edited the summary of this revision. (Show Details)Apr 6 2018, 12:43
deadalnix updated this revision to Diff 3397.Apr 6 2018, 12:44

Remove dependencies

deadalnix removed parent revisions: D1246: Remove reclarations of read_json, create a dedicated header instead, D1245: Add support for scheduler_tests in cmake.Apr 6 2018, 12:45
Closed by commit rABCe5949decf457: Refactor wallet tests as built by cmake (authored by deadalnix). · Explain WhyApr 6 2018, 12:51
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Apr 6 2018, 13:12

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 6 2018, 13:28

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 6 2018, 13:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2242: Diff 3397.Apr 6 2018, 13:54

Revision Contents
Changeset List

PathSize
src/
6 lines
test/
9 lines
wallet/
3 lines
test/

Diff 3394

View Options

src/CMakeLists.txt

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/wallet/CMakeLists.txt

Loading...
View Options

src/wallet/test/CMakeLists.txt

Loading...