Differential D11827

Add a method to make addrman deterministic
ClosedPublic
Actions

Authored by Fabien on Aug 4 2022, 20:20.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCbb9328ffcfe2: Add a method to make addrman deterministic

Summary

This is actually done in tests by subclassing CAddrMan, but making it part of the main CAddrMan class makes it possible to use a deterministic address manager as a member of CConnman. There is no change in behavior.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

addrman_deterministic

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19777
Build 39268: Build Diff	build-debug · build-without-wallet · lint-circular-dependencies · build-diff · build-clang · build-clang-tidy
Build 39267: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 4 2022, 20:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 4 2022, 20:20

Fabien requested review of this revision.Aug 4 2022, 20:20

Fabien added a child revision: D11828: Add unit test for the outbound connection logic.Aug 4 2022, 20:26

Harbormaster completed remote builds in B19773: Diff 34587.Aug 4 2022, 20:38

sdulfari requested changes to this revision.Aug 4 2022, 22:58

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

src/addrman.h
814–816 ↗	(On Diff #34587)	This has better code reuse and makes it much more likely that tests will break cleanly if MakeDeterministic is called part way through the test for some reason.