Paths

Table of Contentst

Fix several tests in script_tests.json
ClosedPublic
Actions

Authored by schancel on Apr 16 2018, 14:38.

Details

Reviewers

deadalnix
jasonbcox
matiu

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rSTAGINGf66412ed9892: Fix several tests in script_tests.json
rABCf66412ed9892: Fix several tests in script_tests.json

Summary

Several of the tests for the new opcodes did
not indicate properly how many bytes they were
pushing on the stack. They were passing due to
serendipity.

Fixes T324

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

script_json

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2323
Build 2783: Bitcoin ABC Buildbot (legacy)
Build 2782: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 16 2018, 14:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2018, 14:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2323: Diff 3514.Apr 16 2018, 15:01

Good catch

This revision is now accepted and ready to land.Apr 16 2018, 15:19

schancel edited the summary of this revision. (Show Details)Apr 16 2018, 15:22

schancel added a task: Restricted Maniphest Task.

Closed by commit rABCf66412ed9892: Fix several tests in script_tests.json (authored by schancel). · Explain WhyApr 16 2018, 15:53

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

data/

script_tests.json

6 lines

Diff 3514

View Options

src/test/data/script_tests.json

Fix several tests in script_tests.jsonClosedPublicActions