[refactor] Add versionbits deployments to deploymentstatus.h
ClosedPublic
Actions

Authored by PiRK on Oct 12 2022, 13:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC31a1fee7fc0d: [refactor] Add versionbits deployments to deploymentstatus.h

Summary

Adds support for versionbits deployments to DeploymentEnabled,
DeploymentActiveAfter and DeploymentActiveAt. Also moves versionbitscache
from validation to deploymentstatus.

This is a partial backport of core#19438
https://github.com/bitcoin/bitcoin/pull/19438/commits/de55304f6e7a8b607e6b3fc7436de50910747b0c

Depends on D12220

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20477
Build 40626: Build Diff	build-diff · build-clang · build-without-wallet · lint-circular-dependencies · build-debug · build-clang-tidy
Build 40625: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 12 2022, 13:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2022, 13:29

PiRK requested review of this revision.Oct 12 2022, 13:29

teamcity edited the summary of this revision. (Show Details)Oct 12 2022, 13:29

PiRK added a child revision: D12221: scripted-diff: rename versionbitscache.Oct 12 2022, 13:36

Harbormaster completed remote builds in B20465: Diff 35618.Oct 12 2022, 13:43

Fabien requested changes to this revision.Oct 12 2022, 15:46

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/deploymentstatus.cpp
12 ↗	(On Diff #35618)	Layout
src/validation.h
17 ↗	(On Diff #35618)	What caused this to be required now ?

This revision now requires changes to proceed.Oct 12 2022, 15:46

PiRK added inline comments.Oct 12 2022, 16:07

src/validation.h
17 ↗	(On Diff #35618)	It previously got included indirectly via versionbits.h. The forward declaration is not enough, because CChain is actually used in several places in validation.h. I will add a note about this and remove the useless forward declartion.

fix comment layout in deploymentstatus.cpp and remove forward declaration of CChain in validation.h (made uneccessary by including chain.h which was previously included indirectly via versionbits.h)

Harbormaster completed remote builds in B20477: Diff 35633.Oct 13 2022, 05:17

Fabien accepted this revision.Oct 13 2022, 08:03

This revision is now accepted and ready to land.Oct 13 2022, 08:03

Closed by commit rABC31a1fee7fc0d: [refactor] Add versionbits deployments to deploymentstatus.h (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyOct 13 2022, 09:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC31a1fee7fc0d: [refactor] Add versionbits deployments to deploymentstatus.h.