Page MenuHomePhabricator

[move-only] Extract constants from addrman .h to .cpp
ClosedPublic

Authored by Fabien on Oct 17 2022, 15:36.

Details

Event Timeline

Fabien requested review of this revision.Oct 17 2022, 15:36

Tail of the build log:

[344/522] Linking CXX shared library src/libbitcoinconsensus.so.0.26.4
[345/522] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[346/522] Linking CXX executable src/bitcoin-cli
[347/522] Linking C executable src/secp256k1/recover-bench
[348/522] Linking C executable src/secp256k1/ecmult-bench
[349/522] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[350/522] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[351/522] Linking C executable src/secp256k1/verify-bench
[352/522] Linking C executable src/secp256k1/sign-bench
[353/522] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[354/522] Linking C executable src/secp256k1/internal-bench
[355/522] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[356/522] Linking CXX executable src/bitcoin-tx
[357/522] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[358/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[359/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[360/522] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[361/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[362/522] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[363/522] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[364/522] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[365/522] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[366/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[367/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[368/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[369/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[370/522] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[371/522] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[372/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[373/522] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[374/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[375/522] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[376/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[377/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[378/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[379/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[380/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[381/522] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[382/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[383/522] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[384/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[385/522] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[386/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[387/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[388/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[389/522] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[390/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[391/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[392/522] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[393/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[394/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[395/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[396/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[397/522] Linking CXX static library src/wallet/libwallet.a
[398/522] Linking CXX static library src/wallet/libwallet-tool.a
[399/522] Linking CXX executable src/bitcoin-wallet
[400/522] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[401/522] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
This revision is now accepted and ready to land.Oct 17 2022, 19:00