Page MenuHomePhabricator
Differential D1283

[Part 4] Refactor logging code into a global object
ClosedPublic
Actions

Authored by jimpo on Apr 12 2018, 19:47.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING724b2c2aa0f9: [Part 4] Refactor logging code into a global object
rABC724b2c2aa0f9: [Part 4] Refactor logging code into a global object
Summary

util: Encapsulate logCategories within BCLog::Logger.

Test Plan

Run bitcoind with different permutations of:
-logtimestamps, -debug, -printtoconsole, -datadir, -shrinkdebugfile

Diff Detail

Repository
rABC Bitcoin ABC
Branch
logging
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/init.cpp:1CFMTCode style violation
Auto-Fixsrc/qt/transactiondesc.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2411
Build 2951: Bitcoin ABC Buildbot (legacy)
Build 2950: arc lint + arc unit

Event Timeline

jimpo created this revision.Apr 12 2018, 19:47
Owners added a reviewer: Restricted Owners Package.Apr 12 2018, 19:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2018, 19:47
jimpo added a parent revision: D1282: [Part 3] Refactor logging code into a global object.Apr 12 2018, 19:48
jimpo added a child revision: D1284: [Part 5] Refactor logging code into a global object.Apr 12 2018, 19:52
teamcity added a subscriber: teamcity.Apr 12 2018, 19:57

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 12 2018, 20:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2300: Diff 3485!Apr 12 2018, 20:08
jasonbcox requested changes to this revision.Apr 14 2018, 00:27
jasonbcox added inline comments.
src/init.cpp
1390 ↗(On Diff #3485)

To avoid these casts, I think flag should be typed as LogFlags. As a result, GetLogCategory should be modified to take LogFlags instead of uint32_t.

This revision now requires changes to proceed.Apr 14 2018, 00:27
jasonbcox accepted this revision.Apr 14 2018, 00:30
jasonbcox added inline comments.
src/init.cpp
1390 ↗(On Diff #3485)

Noticed that you fixed this in https://reviews.bitcoinabc.org/D1284.

This revision is now accepted and ready to land.Apr 14 2018, 00:30
deadalnix added inline comments.Apr 14 2018, 01:04
src/init.cpp
1390 ↗(On Diff #3485)

It still makes the history confusing.

jimpo added inline comments.Apr 14 2018, 19:19
src/init.cpp
1390 ↗(On Diff #3485)

I'm fine with squashing D1284 into this diff you y'all prefer that. I think it's logically separate and better to keep the diffs small, which is why I make there's two diffs right now.

jimpo updated this revision to Diff 3510.Apr 14 2018, 19:31

Rebased.

teamcity added a comment.Apr 14 2018, 19:53

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B2319: Diff 3510!Apr 14 2018, 20:06
teamcity added a comment.Apr 14 2018, 20:06

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

jimpo updated this revision to Diff 3531.Apr 17 2018, 07:51

Rebased.

teamcity added a comment.Apr 17 2018, 08:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B2336: Diff 3531!Apr 17 2018, 08:27
teamcity added a comment.Apr 17 2018, 08:27

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

jimpo updated this revision to Diff 3602.Apr 27 2018, 01:51

Rebased onto master.

teamcity added a comment.Apr 27 2018, 02:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 27 2018, 02:19

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2388: Diff 3602.Apr 27 2018, 02:19
jimpo updated this revision to Diff 3640.Apr 30 2018, 18:01

Rebased.

teamcity added a comment.Apr 30 2018, 18:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 30 2018, 18:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2411: Diff 3640!Apr 30 2018, 18:23
teamcity added a comment.May 1 2018, 00:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 1 2018, 00:35

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2411: Diff 3640.May 1 2018, 00:35
Closed by commit rABC724b2c2aa0f9: [Part 4] Refactor logging code into a global object (authored by jimpo). · Explain WhyMay 1 2018, 01:31
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
15 lines
25 lines
42 lines
qt/
2 lines

Diff 3640

View Options

src/init.cpp

Loading...
View Options

src/logging.h

Loading...
View Options

src/logging.cpp

Loading...
View Options

src/qt/transactiondesc.cpp

Loading...