Differential D12545

[Cashtab] [Extension] [Code cleanup p3 retry] Remove commented out testing code from background.js
ClosedPublic
Actions

Authored by bytesofman on Nov 21 2022, 10:09.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABC4fdf9f2abaa5: [Cashtab] [Extension] [Code cleanup p3 retry] Remove commented out testing code…

Summary

T2751

Depends on D12544

This commented out code is leftover from testing a past diff and should not be in the codebase. Removed.

Test Plan

Confirm only comments removed

Diff Detail

Repository

rABC Bitcoin ABC

Branch

retry-extension-code-quality-audit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21005
Build 41664: Build Diff	cashtab-tests
Build 41663: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 21 2022, 10:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 10:09

bytesofman requested review of this revision.Nov 21 2022, 10:09

bytesofman added a child revision: D12546: [Cashtab] [Extension] [Code cleanup p4 retry] Update comments and function name for triggerUi.Nov 21 2022, 10:11

Harbormaster completed remote builds in B21005: Diff 36422.Nov 21 2022, 10:11

kieran709 accepted this revision.Nov 21 2022, 16:47

This revision is now accepted and ready to land.Nov 21 2022, 16:47

Closed by commit rABC4fdf9f2abaa5: [Cashtab] [Extension] [Code cleanup p3 retry] Remove commented out testing code… (authored by bytesofman). · Explain WhyNov 22 2022, 02:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC4fdf9f2abaa5: [Cashtab] [Extension] [Code cleanup p3 retry] Remove commented out testing code….

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

background.js

7 lines

Diff 36422

View Options

web/cashtab/extension/src/background.js

[Cashtab] [Extension] [Code cleanup p3 retry] Remove commented out testing code from background.jsClosedPublicActions