Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABCc434e5a8023d: [Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name…

Summary

T2751

Depends on D12546

Rename function and clean up comments

Test Plan

npm run extension
Update your local extension build and ensure that it is the only active cashtab extension
go to components.cashtab.com
confirm address sharing still works

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 21 2022, 10:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 10:12

bytesofman requested review of this revision.Nov 21 2022, 10:12

Harbormaster completed remote builds in B21007: Diff 36424.Nov 21 2022, 10:15

kieran709 accepted this revision.Nov 21 2022, 17:03

This revision is now accepted and ready to land.Nov 21 2022, 17:03

Closed by commit rABCc434e5a8023d: [Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name… (authored by bytesofman). · Explain WhyNov 22 2022, 02:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCc434e5a8023d: [Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name….

[Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name for triggerApprovalModal
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 36470

web/cashtab/extension/src/background.js

[Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name for triggerApprovalModalClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36470

web/cashtab/extension/src/background.js

[Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name for triggerApprovalModal
ClosedPublic
Actions

Revision Contents
Changeset List