Differential D12547

[Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name for triggerApprovalModal
ClosedPublic
Actions

Authored by bytesofman on Nov 21 2022, 10:12.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABCc434e5a8023d: [Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name…

Summary

T2751

Depends on D12546

Rename function and clean up comments

Test Plan

npm run extension
Update your local extension build and ensure that it is the only active cashtab extension
go to components.cashtab.com
confirm address sharing still works

Diff Detail

Repository

rABC Bitcoin ABC

Branch

retry-extension-code-quality-audit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21007
Build 41668: Build Diff	cashtab-tests
Build 41667: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 21 2022, 10:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 10:12

bytesofman requested review of this revision.Nov 21 2022, 10:12

Harbormaster completed remote builds in B21007: Diff 36424.Nov 21 2022, 10:15

kieran709 accepted this revision.Nov 21 2022, 17:03

This revision is now accepted and ready to land.Nov 21 2022, 17:03

Closed by commit rABCc434e5a8023d: [Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name… (authored by bytesofman). · Explain WhyNov 22 2022, 02:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCc434e5a8023d: [Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name….

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

background.js

6 lines

Diff 36424

View Options

web/cashtab/extension/src/background.js

[Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name for triggerApprovalModalClosedPublicActions