Differential D12546

[Cashtab] [Extension] [Code cleanup p4 retry] Update comments and function name for triggerUi
ClosedPublic
Actions

Authored by bytesofman on Nov 21 2022, 10:11.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC3293b9c544fe: [Cashtab] [Extension] [Code cleanup p4 retry] Update comments and function name…

Summary

T2751

Depends on D12545

Originally, triggerUi was modeled on a metamask generalist function. However in Cashtab it is only used for opening a window to send a prepopulated xec tx.

Update the comments and function name to reflect this.

Test Plan

npm run extension
Update your local unpacked extension
Navigate to components.cashtab.com
Click on Cashtab Pay button for the standard Cashtab Badge component
Cashtab extension should open with tx populated

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 21 2022, 10:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 10:11

bytesofman requested review of this revision.Nov 21 2022, 10:11

bytesofman added a child revision: D12547: [Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name for triggerApprovalModal.

Harbormaster completed remote builds in B21006: Diff 36423.Nov 21 2022, 10:30

kieran709 accepted this revision.Nov 21 2022, 16:51

This revision is now accepted and ready to land.Nov 21 2022, 16:51

Closed by commit rABC3293b9c544fe: [Cashtab] [Extension] [Code cleanup p4 retry] Update comments and function name… (authored by bytesofman). · Explain WhyNov 22 2022, 02:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC3293b9c544fe: [Cashtab] [Extension] [Code cleanup p4 retry] Update comments and function name….

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

22 lines

Diff 36469

web/cashtab/extension/src/background.js

Loading...