Page MenuHomePhabricator

[Cashtab] [Extension] [Code cleanup p4 retry] Update comments and function name for triggerUi
ClosedPublic

Authored by bytesofman on Nov 21 2022, 10:11.

Details

Summary

T2751

Depends on D12545

Originally, triggerUi was modeled on a metamask generalist function. However in Cashtab it is only used for opening a window to send a prepopulated xec tx.

Update the comments and function name to reflect this.

Test Plan

npm run extension
Update your local unpacked extension
Navigate to components.cashtab.com
Click on Cashtab Pay button for the standard Cashtab Badge component
Cashtab extension should open with tx populated

Diff Detail

Repository
rABC Bitcoin ABC
Branch
retry-extension-code-quality-audit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21006
Build 41666: Build Diffcashtab-tests
Build 41665: arc lint + arc unit