Differential D12556

node/chainstate: Decouple from GetTimeMillis
ClosedPublic
Actions

Authored by Fabien on Nov 21 2022, 14:32.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCd0f1c29cd5c4: node/chainstate: Decouple from GetTimeMillis

Summary

...instead just move it out

Partial backport of core#23280:
https://github.com/bitcoin/bitcoin/pull/23280/commits/cbac28b72f5b831f6f84b7628f73e85627af3d94

Depends on D12555.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR23280_p2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21018
Build 41690: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 41689: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 21 2022, 14:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 14:32

Fabien requested review of this revision.Nov 21 2022, 14:32

teamcity edited the summary of this revision. (Show Details)Nov 21 2022, 14:32

Fabien added a child revision: D12557: node/chainstate: Decouple from stringy errors.Nov 21 2022, 14:32

Harbormaster completed remote builds in B21018: Diff 36436.Nov 21 2022, 14:47

PiRK accepted this revision.Nov 21 2022, 15:26

This revision is now accepted and ready to land.Nov 21 2022, 15:26

Closed by commit rABCd0f1c29cd5c4: node/chainstate: Decouple from GetTimeMillis (authored by Carl Dong <contact@carldong.me>, committed by Fabien). · Explain WhyNov 21 2022, 19:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd0f1c29cd5c4: node/chainstate: Decouple from GetTimeMillis.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

6 lines

node/

chainstate.cpp

3 lines

Diff 36436

View Options

src/init.cpp