Page MenuHomePhabricator
Differential D12551

rpc: Return block time in getblockchaininfo
ClosedPublic
Actions

Authored by Fabien on Nov 21 2022, 12:26.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCf7e15e8c8957: rpc: Return block time in getblockchaininfo
Summary
Return tip time in getblockchaininfo, for some use cases this can save a call to getblock.

Backport of core#22407.

Depends on D12550.

Test Plan
./test/functional/test_runner.py rpc_blockchain

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 21 2022, 12:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 12:26
Fabien requested review of this revision.Nov 21 2022, 12:26
teamcity edited the summary of this revision. (Show Details)Nov 21 2022, 12:26
Fabien added a child revision: D12552: test: improve rpc_blockchain.py tests and assert on time and mediantime.Nov 21 2022, 12:42
Harbormaster completed remote builds in B21013: Diff 36431.Nov 21 2022, 12:46
PiRK accepted this revision.Nov 21 2022, 15:04
PiRK added a subscriber: PiRK.

Review note: GetBlockTime() and GetMedianTimePast() return an int64_t, so casting the value is unnecessary.

This revision is now accepted and ready to land.Nov 21 2022, 15:04
Closed by commit rABCf7e15e8c8957: rpc: Return block time in getblockchaininfo (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyNov 21 2022, 17:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf7e15e8c8957: rpc: Return block time in getblockchaininfo.

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
rpc/
9 lines
test/
functional/
3 lines

Diff 36451

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

test/functional/rpc_blockchain.py

Loading...