refactor: Pass block reference instead of pointer to PeerManagerImpl::BlockRequested
ClosedPublic
Actions

Authored by PiRK on Dec 1 2022, 08:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCae58662f6249: refactor: Pass block reference instead of pointer to PeerManagerImpl…

Summary

This allows to remove an assert and at the same time make it more obvious that the block is never nullptr.

This is a backport of core#22221

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20295

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21291
Build 42232: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-diff · build-clang-tidy · build-clang
Build 42231: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 1 2022, 08:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2022, 08:56

PiRK requested review of this revision.Dec 1 2022, 08:56

teamcity edited the summary of this revision. (Show Details)Dec 1 2022, 08:56

Harbormaster completed remote builds in B21291: Diff 36869.Dec 1 2022, 09:12

Fabien accepted this revision.Dec 1 2022, 09:12

This revision is now accepted and ready to land.Dec 1 2022, 09:12

Closed by commit rABCae58662f6249: refactor: Pass block reference instead of pointer to PeerManagerImpl… (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyDec 1 2022, 10:49

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCae58662f6249: refactor: Pass block reference instead of pointer to PeerManagerImpl….

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

15 lines

Diff 36869

View Options

refactor: Pass block reference instead of pointer to PeerManagerImpl::BlockRequestedClosedPublicActions