[xec-web-components][Pt2] Components lib: Use styled-components
AbandonedPublic
Actions

Authored by kieran709 on Dec 6 2022, 06:50.

Details

Reviewers

bytesofman
emack

Group Reviewers

Restricted Project

Summary

Depends on D12772. This diff adds styled-components to the library's peerDependencies. This diff will cause the build script to fail as the TestComponent uses an external CSS file. In a later diff which will update the component generation script, the TestComponent will be replaced with a new boiler plate component that passes the build process.

This diff is based on the styled-component branch found here: https://github.com/HarveyD/react-component-library/compare/master...styled-components

Test Plan

cd web/xec-web-components
npm run storybook
observe that storybook runs

npm run build
build will fail as postcss plugin has been removed from rollup.config.js

Diff Detail

Repository

rABC Bitcoin ABC

Branch

xec-web-components

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21396
Build 42442: Build Diff
Build 42441: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 6 2022, 06:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 6 2022, 06:50

kieran709 requested review of this revision.Dec 6 2022, 06:50

Harbormaster completed remote builds in B21396: Diff 37015.Dec 6 2022, 06:51

kieran709 added a child revision: D12800: [xec-web-components][Pt3] Add changes from code-splitting branch.Dec 7 2022, 16:48

build will fail as postcss plugin has been removed from rollup.config.js

Why was postcss plugin removed?

This revision now requires changes to proceed.Dec 10 2022, 13:52

kieran709 edited the summary of this revision. (Show Details)Dec 12 2022, 18:54

In this diff, I am using the example provided here: https://github.com/HarveyD/react-component-library/compare/master...styled-components. As far as I can tell postcss doesn't run on styled components, though I may be able to find a plugin that will accomplish this if needed.

kieran709 abandoned this revision.Dec 16 2022, 01:14