Related to T1955. Initial commit for the xec-web-components library. The scaffolding for this project comes from: https://github.com/HarveyD/react-component-library.
Details
Details
- Reviewers
bytesofman emack Fabien - Group Reviewers
Restricted Project
npm i
cd xec-web-components
npm run storybook
observe that storybook is running
npm run build
observe that the rollup build maintains the file structure.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- xec-web-components
- Lint
Lint Passed Severity Location Code Message Auto-Fix web/xec-web-components/README.md:1 PRETTIER Code style violation - Unit
No Test Coverage - Build Status
Buildable 21395 Build 42440: Build Diff Build 42439: arc lint + arc unit
Event Timeline
Comment Actions
This is adding ~43,000 lines of code, which seems to be generic library type stuff.... why do we want to add this to our repo?
| web/xec-web-components/package.json | ||
|---|---|---|
| 22 | That's not our repo | |
| web/xec-web-components/package.json | ||
|---|---|---|
| 22 | Joey asked me here: https://reviews.bitcoinabc.org/D12686 to import the repo exactly as it is, so there are still plenty of cleanup tasks that will need come later in the stack. In trying to keep each diff in the stack focused, I thought it would be preferable to avoid making changes that are not related to the initial commit Joey requested, but deal with them individually later in the stack. That being said, it is certainly an easy fix that I would be happy to make in Pt1 of this stack. I've just msg'd Joey about it and will run with whatever the team thinks is best once I get more feedback. | |