Page MenuHomePhabricator
Differential D12916

Copy the smart pointer rather then the raw tx when adding a mempool tx to the wallet
ClosedPublic
Actions

Authored by Fabien on Dec 19 2022, 17:49.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC5014dfca6c39: Copy the smart pointer rather then the raw tx when adding a mempool tx to the…
Summary

This will allow for making CTransaction non copyable, and force the use of CTransactionRef so we only keep a single pointer to a transaction for all its uses through the codebase.

Test Plan
ninja all check-all
./test/functional/test_runner.py wallet*
./contrib/teamcity/build-configurations.py build-asan

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 19 2022, 17:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2022, 17:49
Fabien requested review of this revision.Dec 19 2022, 17:49
Harbormaster completed remote builds in B21629: Diff 37368.Dec 19 2022, 18:07
PiRK accepted this revision.Dec 20 2022, 08:53
PiRK added a subscriber: PiRK.

nit: in the summary, you probably meant "codebase" instead of "coinbase"

This revision is now accepted and ready to land.Dec 20 2022, 08:53
Fabien edited the summary of this revision. (Show Details)Dec 20 2022, 08:54
Fabien edited the summary of this revision. (Show Details)
Closed by commit rABC5014dfca6c39: Copy the smart pointer rather then the raw tx when adding a mempool tx to the… (authored by Fabien). · Explain WhyDec 20 2022, 14:31
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC5014dfca6c39: Copy the smart pointer rather then the raw tx when adding a mempool tx to the….

Revision Contents
Changeset List

PathSize
src/
wallet/
17 lines

Diff 37387

View Options

src/wallet/wallet.cpp

Loading...