Page MenuHomePhabricator
Differential D1364

[rpc] remove missed rpc parameters
ClosedPublic
Actions

Authored by schancel on May 3 2018, 03:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING88b5f72133ab: [rpc] remove missed rpc parameters
rABC88b5f72133ab: [rpc] remove missed rpc parameters
Summary

Clean up RPC parameter mapping for estimatesmartpriority and estimatepriority,
which were removed in D1353 and D1350.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
clean-rpc-params
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2487
Build 3103: Bitcoin ABC Buildbot (legacy)
Build 3102: arc lint + arc unit

Event Timeline

schancel created this revision.May 3 2018, 03:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2018, 03:58
teamcity added a subscriber: teamcity.May 3 2018, 03:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 3 2018, 04:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2487: Diff 3747!May 3 2018, 04:21
jasonbcox added a subscriber: jasonbcox.May 3 2018, 20:52
jasonbcox added inline comments.
src/rpc/client.cpp
107

Is it possible to write a test that detects RPC params in this list that do not have an implementation? That way, we don't have to worry about this in the future.

deadalnix added a subscriber: deadalnix.May 4 2018, 16:16
deadalnix added inline comments.
src/rpc/client.cpp
107

startrekagree

deadalnix added a comment.May 4 2018, 16:18

Or even better, have a way to specify this with the RPC call, not is some 3rd party data-structure.

schancel added inline comments.May 6 2018, 05:02
src/rpc/client.cpp
107

I will look into it as soon as I get the fees stuff working. This can sit until then.

deadalnix accepted this revision.May 6 2018, 22:56
deadalnix added inline comments.
src/rpc/client.cpp
107

I trust you. Please make sure you make a task for it, we know this is tech debt that needs to be cleaned up.

This revision is now accepted and ready to land.May 6 2018, 22:56
Closed by commit rABC88b5f72133ab: [rpc] remove missed rpc parameters (authored by schancel). · Explain WhyMay 8 2018, 00:02
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.May 8 2018, 00:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B2487: Diff 3747!May 8 2018, 00:03
teamcity added a comment.May 8 2018, 00:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines

Diff 3747

View Options

src/rpc/client.cpp

Loading...