[avalanche] Add field to the getavalancheinfo RPC to monitor if our proof is shared
ClosedPublic
Actions

Authored by Fabien on Jan 24 2023, 14:26.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC964a64e6311a: [avalanche] Add field to the getavalancheinfo RPC to monitor if our proof is…

Summary

Since D13030 the node is waiting for an inbound connection before it can share the local proof with the avalanche network. This diff adds a new field to the getavalancheinfo RPC to monitor this status.

Depends on D13030.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_rpc_ready_to_vote

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21860
Build 43355: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43354: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 24 2023, 14:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 14:26

Fabien requested review of this revision.Jan 24 2023, 14:26

Harbormaster completed remote builds in B21851: Diff 37695.Jan 24 2023, 14:38

Patch is good. I will leave final call on the naming to you.

src/rpc/avalanche.cpp
661 ↗	(On Diff #37695)	`is_sharing` or `is_advertising` make more sense to me. `ready_to_share` is not clear if it is currently sharing or just able to.