Page MenuHomePhabricator

[tests] show the proofid when representing a proof
ClosedPublic

Authored by PiRK on Feb 2 2023, 17:33.

Details

Reviewers
sdulfari
Fabien
Group Reviewers
Restricted Project
Commits
rABC395893c395cf: [tests] show the proofid when representing a proof
Summary

This would have made it easier to debug the issue fixed by D13099, to verify that the received msg_avaproof was indeed the one corresponding to the sent msg_getdata before comparing the timestamps.

Test Plan

Make a test involving a msg_avaproof (e.g. abc_p2p_compactproofs) fail and inspect the log for a msg_avaproof.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
proofid_in_proof_repr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21934
Build 43503: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43502: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Feb 2 2023, 17:33
sdulfari requested changes to this revision.Feb 2 2023, 19:33
sdulfari added a subscriber: sdulfari.

Include limited_proofid too

This revision now requires changes to proceed.Feb 2 2023, 19:33

include also limited_proofid in repr

Fabien requested changes to this revision.Feb 5 2023, 11:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/messages.py
954

We now have uint256_hex in util.py

This revision now requires changes to proceed.Feb 5 2023, 11:59
This revision is now accepted and ready to land.Feb 14 2023, 22:17