Page MenuHomePhabricator
Differential D1388

Add accessors for transaction id and n in COutPoint
ClosedPublic
Actions

Authored by deadalnix on May 9 2018, 00:16.

Details

Reviewers
matiu
Group Reviewers
Restricted Project
Commits
rSTAGINGbb047ea41bcb: Add accessors for transaction id and n in COutPoint
rABCbb047ea41bcb: Add accessors for transaction id and n in COutPoint
Summary

This is a first step toward getting more of the codebase to use TxId. Doing the migration is hard when all kind of code touches the fields directly, so the first action item is to go through constructor/accessors.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
outpointaccessor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2545
Build 3207: Bitcoin ABC Buildbot (legacy)
Build 3206: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 9 2018, 00:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 9 2018, 00:16
teamcity added a subscriber: teamcity.May 9 2018, 00:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix added a child revision: D1389: Update Coin code to use COutPoint via constructor/accessor.May 9 2018, 00:31
teamcity added a comment.May 9 2018, 00:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix added a child revision: D1390: Update core_write.cpp to use COutPoint's accessors.May 9 2018, 00:41
deadalnix added a child revision: D1391: Ensure qt uses the COutPoint accessors.May 9 2018, 00:49
teamcity added a comment.May 9 2018, 00:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added a child revision: D1392: Move RPC code to use COutPoint accessors.May 9 2018, 00:55
Harbormaster completed remote builds in B2545: Diff 3821.May 9 2018, 00:55
deadalnix added a child revision: D1393: Use COutPoint accessors in the wallet code.May 9 2018, 01:04
deadalnix added a child revision: D1394: Use COutPoint in the mempool code.May 9 2018, 01:11
deadalnix added a child revision: D1395: Update script code to use COutPoint's accessor.May 9 2018, 01:18
matiu accepted this revision.May 9 2018, 01:20
This revision is now accepted and ready to land.May 9 2018, 01:20
deadalnix added a child revision: D1396: Use COutPoint's accessors in validation code and tests..May 9 2018, 01:38
deadalnix added a child revision: D1397: Use COutPoint's accessor in the txdb code.May 9 2018, 01:43
deadalnix added a child revision: D1398: Use COutPoint's accessors in the network code.May 9 2018, 01:47
deadalnix added a child revision: D1399: Update various tests to use COutPoint's accessors.May 9 2018, 02:01
Closed by commit rABCbb047ea41bcb: Add accessors for transaction id and n in COutPoint (authored by deadalnix). · Explain WhyMay 9 2018, 10:35
This revision was automatically updated to reflect the committed changes.
deadalnix added a child revision: D1401: Update policyestimator_tests to use COutPoint's accessor..May 9 2018, 11:49
deadalnix added a child revision: D1402: Use COutPoint's accesors in miner_tests.cpp.May 9 2018, 12:12

Revision Contents
Changeset List

PathSize
src/
primitives/
8 lines

Diff 3821

View Options

src/primitives/transaction.h

Loading...