Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC88e5352e2b63: [Chronik] Move ffi::Block into chronik-bridge, use CBlockIndex and CBlock

Summary

Move ffi::Block from chronik-lib to chronik-bridge. This allows us to use this type in other crates, e.g. chronik-indexer.
Add ffi definitions for CBlockIndex and CBlock so we can use them in Rust.
Expose BridgeBlock through ffi so we can use it in Rust, renamed to bridge_block.
Change handle_block_connected and handle_block_disconnected to take &CBlock and &CBlockIndex.

Test Plan

ninja check-crates && ninja && ./test/functional/test_runner chronik_block

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-cblockindex

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22395
Build 44416: Build Diff	build-chronik
Build 44415: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Mar 10 2023, 21:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 10 2023, 21:14

tobias_ruck added a child revision: D13277: [Chronik] Resync index.Mar 10 2023, 21:17

Harbormaster completed remote builds in B22331: Diff 38400.Mar 10 2023, 21:30

Also add CBlock, which we will need once we process txs

tobias_ruck retitled this revision from [Chronik] Refactor, move ffi::Block into chronik-bridge, add CBlockIndex to [Chronik] Move ffi::Block into chronik-bridge, add & use CBlockIndex and CBlock.Mar 11 2023, 07:16

tobias_ruck edited the summary of this revision. (Show Details)

tobias_ruck edited the test plan for this revision. (Show Details)

tobias_ruck retitled this revision from [Chronik] Move ffi::Block into chronik-bridge, add & use CBlockIndex and CBlock to [Chronik] Move ffi::Block into chronik-bridge, use CBlockIndex and CBlock.

tobias_ruck published this revision for review.Mar 11 2023, 07:19

Harbormaster completed remote builds in B22347: Diff 38416.Mar 11 2023, 07:21

Move bridge_block below get_chain_tip

Harbormaster completed remote builds in B22348: Diff 38417.Mar 11 2023, 07:34

[Chronik] Add ChronikBridge::lookup_block_index

This allows us to get a CBlockIndex from a hash.

Revert accidental amend

tobias_ruck added a child revision: D13288: [Chronik] Add `ChronikBridge::lookup_block_index`.Mar 11 2023, 08:06

Harbormaster completed remote builds in B22350: Diff 38419.Mar 11 2023, 08:11

Harbormaster completed remote builds in B22351: Diff 38420.Mar 11 2023, 08:21

@bot build-linux64 build-linux-aarch64 build-linux-arm build-osx build-win64

teamcity awarded a token.Mar 11 2023, 10:40