Page MenuHomePhabricator
Differential D13294

[Chronik] Generate Chronik port for functional test
ClosedPublic
Actions

Authored by tobias_ruck on Mar 11 2023, 13:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC83358c5c7ea8: [Chronik] Generate Chronik port for functional test
Summary

Currently, chronik_block.py and chronik_serve.py sometimes fail, as their node ports overlap.

We add the same port allocation mechanism as for p2p_port and rpc_port to fix this.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-test-port-assignment
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22397
Build 44420: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 44419: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Mar 11 2023, 13:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2023, 13:49
tobias_ruck requested review of this revision.Mar 11 2023, 13:49
tobias_ruck mentioned this in D13277: [Chronik] Resync index.Mar 11 2023, 13:55
tobias_ruck added a child revision: D13277: [Chronik] Resync index.Mar 11 2023, 14:02
Harbormaster completed remote builds in B22364: Diff 38434.Mar 11 2023, 14:06
Fabien requested changes to this revision.Mar 13 2023, 08:49
Fabien added inline comments.
test/functional/test_framework/util.py
400 ↗(On Diff #38434)

That's the 3rd copy pasta, time to clean this up

This revision now requires changes to proceed.Mar 13 2023, 08:49
tobias_ruck updated this revision to Diff 38481.Mar 13 2023, 11:35

un-copy-pasta port allocation code

Harbormaster completed remote builds in B22396: Diff 38481.Mar 13 2023, 11:35
tobias_ruck updated this revision to Diff 38482.Mar 13 2023, 11:37

arc diff linter betrayed me

Harbormaster completed remote builds in B22397: Diff 38482.Mar 13 2023, 11:53
Fabien accepted this revision.Mar 13 2023, 12:16
Fabien added inline comments.
test/functional/test_framework/util.py
361
This revision is now accepted and ready to land.Mar 13 2023, 12:16
tobias_ruck updated this revision to Diff 38498.Mar 13 2023, 12:35

update comment for unique_port

Harbormaster completed remote builds in B22406: Diff 38498.Mar 13 2023, 13:27
Closed by commit rABC83358c5c7ea8: [Chronik] Generate Chronik port for functional test (authored by tobias_ruck). · Explain WhyMar 13 2023, 14:42
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC83358c5c7ea8: [Chronik] Generate Chronik port for functional test.

Revision Contents
Changeset List

PathSize
test/
functional/
3 lines
2 lines
test_framework/
3 lines
3 lines
65 lines

Diff 38482

View Options

test/functional/chronik_block.py

Loading...
View Options

test/functional/chronik_serve.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...