Differential D1403

Make COutPoint's fields private
ClosedPublic
Actions

Authored by deadalnix on May 9 2018, 12:26.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING3b3c27dc62d5: Make COutPoint's fields private
rABC3b3c27dc62d5: Make COutPoint's fields private

Summary

As per title.

Depends on D1389, D1390, D1391, D1392, D1393, D1394, D1395, D1396, D1397, D1398, D1399, D1401, D1402

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

outpointpriv

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2563
Build 3243: Bitcoin ABC Buildbot (legacy)
Build 3242: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 9 2018, 12:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 9 2018, 12:26

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2563: Diff 3849.May 9 2018, 12:49

deadalnix mentioned this in D1404: Use TxId internally in COutPoint.May 9 2018, 12:55

deadalnix added a child revision: D1405: Remove COutPoint::SetNull.May 9 2018, 13:20

deadalnix added a child revision: D1404: Use TxId internally in COutPoint.May 9 2018, 13:22

jasonbcox accepted this revision.May 9 2018, 20:37

This revision is now accepted and ready to land.May 9 2018, 20:37

Closed by commit rABC3b3c27dc62d5: Make COutPoint's fields private (authored by deadalnix). · Explain WhyMay 11 2018, 22:30

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

primitives/

transaction.h

21 lines

transaction.cpp

2 lines

test/

multisig_tests.cpp

11 lines

transaction_tests.cpp

17 lines

Diff 3849

View Options

src/primitives/transaction.h

View Options

src/primitives/transaction.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/transaction_tests.cpp

Make COutPoint's fields privateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3849

src/primitives/transaction.h

src/primitives/transaction.cpp

src/test/multisig_tests.cpp

src/test/transaction_tests.cpp

Make COutPoint's fields private
ClosedPublic
Actions

Revision Contents
Changeset List