Differential D1405

Remove COutPoint::SetNull
ClosedPublic
Actions

Authored by deadalnix on May 9 2018, 13:12.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGb987db4887d5: Remove COutPoint::SetNull
rABCb987db4887d5: Remove COutPoint::SetNull

Summary

Make the COutPoint class stateless.

Depends on D1403

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

outpointnosetnull

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2565
Build 3247: Bitcoin ABC Buildbot (legacy)
Build 3246: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 9 2018, 13:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 9 2018, 13:12

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix edited the summary of this revision. (Show Details)May 9 2018, 13:20

deadalnix added a parent revision: D1403: Make COutPoint's fields private.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2565: Diff 3851.May 9 2018, 13:36

jasonbcox accepted this revision.May 9 2018, 20:44

This revision is now accepted and ready to land.May 9 2018, 20:44

Closed by commit rABCb987db4887d5: Remove COutPoint::SetNull (authored by deadalnix). · Explain WhyMay 11 2018, 22:36

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

bench/

mempool_eviction.cpp

8 lines

miner.cpp

2 lines

primitives/

transaction.h

7 lines

test/

8 lines

2 lines

2 lines

2 lines

transaction_tests.cpp

2 lines

Diff 3851

View Options

src/bench/mempool_eviction.cpp

View Options

src/miner.cpp

View Options

src/primitives/transaction.h

View Options

src/test/mempool_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sigopcount_tests.cpp

View Options

src/test/transaction_tests.cpp

Remove COutPoint::SetNullClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3851

src/bench/mempool_eviction.cpp

src/miner.cpp

src/primitives/transaction.h

src/test/mempool_tests.cpp

src/test/miner_tests.cpp

src/test/script_tests.cpp

src/test/sigopcount_tests.cpp

src/test/transaction_tests.cpp

Remove COutPoint::SetNull
ClosedPublic
Actions

Revision Contents
Changeset List