Page MenuHomePhabricator
Differential D1407

Fixes `--enable-asan` compilation in MacOS
ClosedPublic
Actions

Authored by matiu on May 9 2018, 20:10.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGd3fab49e71b8: Fixes `--enable-asan` compilation in MacOS
rABCd3fab49e71b8: Fixes `--enable-asan` compilation in MacOS
Summary

This fixes --enable-asan linkage for MacOS.

--fsanitize=address is not passed by default by libtool when linking libbitcoinconsesus, probably because of https://www.gnu.org/software/libtool/manual/html_node/Stripped-link-flags.html

By simply adding the flag in LIBTOOL_APP_LDFLAGS, the option is pass, and the library created successfully.

For Address sanitation, it is necesary to disable assembly (--disable-asm) in MacOS, the llvm compiler doesnt seem to understand the inline asm format with using --enable-asan, not sure why.

Test Plan

./configure --enable-asan --disable-asm && make && ./src/test/test_bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
asan
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2577
Build 3271: Bitcoin ABC Buildbot (legacy)
Build 3270: arc lint + arc unit

Event Timeline

matiu created this revision.May 9 2018, 20:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 9 2018, 20:10
teamcity added a subscriber: teamcity.May 9 2018, 20:10

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel added a subscriber: schancel.May 9 2018, 20:16

Are we doing anything about these builds under cmake?

teamcity added a comment.May 9 2018, 20:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2567: Diff 3855.May 9 2018, 20:33
deadalnix added a subscriber: deadalnix.May 9 2018, 20:56
deadalnix added inline comments.
configure.ac
242 ↗(On Diff #3855)

This doesn't seems like the right place to add this.

253 ↗(On Diff #3855)

Here seems more appropriate.

matiu updated this revision to Diff 3873.May 10 2018, 18:45

More LIBTOOL_APP_LDFLAGS config to a more appropiate place

teamcity added a comment.May 10 2018, 18:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 10 2018, 19:07

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2577: Diff 3873!May 10 2018, 19:07
deadalnix accepted this revision.May 11 2018, 22:35
This revision is now accepted and ready to land.May 11 2018, 22:35
Closed by commit rABCd3fab49e71b8: Fixes `--enable-asan` compilation in MacOS (authored by matiu). · Explain WhyMay 21 2018, 06:28
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines

Diff 3873

View Options

configure.ac

Loading...