Page MenuHomePhabricator
Differential D13550

scripts: security-check.py refactors
ClosedPublic
Actions

Authored by PiRK on Apr 4 2023, 07:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe2b43d59aebc: scripts: security-check.py refactors
Summary

scripts: no-longer check for 32 bit windows in security-check.py

scripts: remove NONFATAL from security-check.py

scripts: add run_command to security-check.py

Deduplicate all the subprocess code.

scripts: add additional type annotations to security-check.py

This is a backport of core#18796

Test Plan

gitian builds

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22977
Build 45574: Build Diff
Build 45573: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 4 2023, 07:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 4 2023, 07:42
teamcity edited the summary of this revision. (Show Details)Apr 4 2023, 07:42
Harbormaster completed remote builds in B22934: Diff 39193.Apr 4 2023, 07:42
PiRK added a comment.Apr 4 2023, 07:43

@bot gitian-osx gitian-linux gitian-win

teamcity awarded a token.Apr 4 2023, 07:43
PiRK updated this revision to Diff 39260.Apr 5 2023, 09:37

rebase and simplify some return statements for booleans

Harbormaster completed remote builds in B22977: Diff 39260.Apr 5 2023, 09:37
PiRK published this revision for review.Apr 5 2023, 09:37

@bot gitian-osx gitian-linux gitian-win

teamcity updated a token.Apr 5 2023, 09:39
PiRK added a child revision: D13575: build: add -Wl,-z,separate-code to hardening flags.Apr 5 2023, 09:42
Fabien accepted this revision.Apr 5 2023, 10:36
This revision is now accepted and ready to land.Apr 5 2023, 10:36
Closed by commit rABCe2b43d59aebc: scripts: security-check.py refactors (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyApr 5 2023, 12:46
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe2b43d59aebc: scripts: security-check.py refactors.

Revision Contents
Changeset List

PathSize
contrib/
devtools/
163 lines

Diff 39260

View Options

contrib/devtools/security-check.py

Loading...