Page MenuHomePhabricator
Differential D13576

[cmake] Check the linker flags against the actual linker
ClosedPublic
Actions

Authored by Fabien on Apr 5 2023, 11:02.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCf512af6ab39d: [cmake] Check the linker flags against the actual linker
Summary

The linker flag are currently tested against the default toolchain linker, but different linkers might have different features and support different flag sets.

Test Plan
ninja all

Run the gitian builds

Diff Detail

Event Timeline

Fabien created this revision.Apr 5 2023, 11:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2023, 11:02
Fabien requested review of this revision.Apr 5 2023, 11:02
Fabien added a comment.Apr 5 2023, 11:02

@bot gitian-linux gitian-osx gitian-win

teamcity awarded a token.Apr 5 2023, 11:02
Harbormaster completed remote builds in B22981: Diff 39268.Apr 5 2023, 11:31
Fabien updated this revision to Diff 39272.Apr 5 2023, 11:46

Don't squash with other diffs

Harbormaster completed remote builds in B22984: Diff 39272.Apr 5 2023, 12:01
PiRK accepted this revision.Apr 5 2023, 12:42
PiRK added a subscriber: PiRK.

It works for me.

This revision is now accepted and ready to land.Apr 5 2023, 12:42
PiRK mentioned this in D13575: build: add -Wl,-z,separate-code to hardening flags.Apr 5 2023, 12:50
PiRK added a child revision: D13575: build: add -Wl,-z,separate-code to hardening flags.Apr 5 2023, 12:51
Closed by commit rABCf512af6ab39d: [cmake] Check the linker flags against the actual linker (authored by Fabien). · Explain WhyApr 5 2023, 12:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf512af6ab39d: [cmake] Check the linker flags against the actual linker.

Revision Contents
Changeset List

PathSize
cmake/
modules/
6 lines
src/
9 lines

Diff 39268

View Options

cmake/modules/AddCompilerFlags.cmake

Loading...
View Options

src/CMakeLists.txt

Loading...