Page MenuHomePhabricator

[alias-server] match output scripts for p2pkh or p2sh registration address
ClosedPublic

Authored by bytesofman on Apr 6 2023, 18:15.

Details

Summary

T3060

Depends on D13606

Remove hard-coded outputScript matcher used to parse valid alias txs.

Add unit tested function to get the desired outputScript from address.

Modify calls to functions with modified params.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-functions-address-input
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23054
Build 45728: Build Diffalias-server-tests
Build 45727: arc lint + arc unit

Event Timeline

Remove now-unused hash160 param

undo order change in config.js

Fabien requested changes to this revision.Apr 7 2023, 08:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/alias-server/src/alias.js
99

That's no longer what this is doing, it can be p2sh

This revision now requires changes to proceed.Apr 7 2023, 08:35

remove p2pkh specific comments

This revision is now accepted and ready to land.Apr 7 2023, 14:24