Page MenuHomePhabricator
Differential D13618

[tg bot] Unit test for main()
ClosedPublic
Actions

Authored by bytesofman on Apr 7 2023, 18:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9785bd8e9d4e: [tg bot] Unit test for main()
Summary

T2972

Depends on D13617

Unit test app starting function, main. chronikMock.js is improved to return more realistic websocket info.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-refactor-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23086
Build 45792: Build Diffecash-herald-tests
Build 45791: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 7 2023, 18:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2023, 18:12
bytesofman requested review of this revision.Apr 7 2023, 18:12
Harbormaster completed remote builds in B23085: Diff 39410.Apr 7 2023, 18:13
bytesofman updated this revision to Diff 39411.Apr 7 2023, 18:26

test failure case

Harbormaster completed remote builds in B23086: Diff 39411.Apr 7 2023, 18:27
bytesofman added a child revision: D13619: [herald] Remove un-needed .js from scripts in package.json.Apr 7 2023, 18:29
Fabien accepted this revision.Apr 9 2023, 06:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/index.js
14

unrelated: doesn't channelId belong to the telegramBot ? Same question for the address and chronik

apps/ecash-herald/src/main.js
46

you just failed to initialize your tg bot, I can't really imagine that you would be able to send a message even via another channel

This revision is now accepted and ready to land.Apr 9 2023, 06:50
bytesofman updated this revision to Diff 39494.Apr 10 2023, 16:30

rebase

Harbormaster completed remote builds in B23159: Diff 39494.Apr 10 2023, 16:30
Closed by commit rABC9785bd8e9d4e: [tg bot] Unit test for main() (authored by bytesofman). · Explain WhyApr 12 2023, 14:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC9785bd8e9d4e: [tg bot] Unit test for main().

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
23 lines
src/
52 lines
test/
47 lines
mocks/
13 lines

Diff 39411

View Options

apps/ecash-herald/index.js

Loading...
View Options

apps/ecash-herald/src/main.js

Loading...
View Options

apps/ecash-herald/test/mainTests.js

Loading...
View Options

apps/ecash-herald/test/mocks/chronikMock.js

Loading...