Page MenuHomePhabricator
Differential D13622

[herald] Refactor handleBlockConnected to support multiple api calls later
ClosedPublic
Actions

Authored by bytesofman on Apr 7 2023, 21:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0e9ca4eec6be: [herald] Refactor handleBlockConnected to support multiple api calls later
Summary

T2972

Depends on D13620

Refactor handleBlockConnected so that chronik API call has its own try...catch block

Future API calls will also need their own try...catch blocks

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23162
Build 45943: Build Diff
Build 45942: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 7 2023, 21:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2023, 21:38
bytesofman requested review of this revision.Apr 7 2023, 21:38
Harbormaster completed remote builds in B23090: Diff 39415.Apr 7 2023, 21:40
bytesofman added a child revision: D13623: [herald] Default msg should be in HTML, not markdown.Apr 7 2023, 21:46
Fabien requested changes to this revision.Apr 9 2023, 06:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/src/events.js
38 ↗(On Diff #39415)

return await

49 ↗(On Diff #39415)

return false in the catch

This revision now requires changes to proceed.Apr 9 2023, 06:59
bytesofman updated this revision to Diff 39486.Apr 10 2023, 16:14

responding to feedback

Harbormaster completed remote builds in B23151: Diff 39486.Apr 10 2023, 16:14
bytesofman updated this revision to Diff 39497.Apr 10 2023, 16:31

rebase

Harbormaster completed remote builds in B23162: Diff 39497.Apr 10 2023, 16:31
Fabien accepted this revision.Apr 10 2023, 18:55
This revision is now accepted and ready to land.Apr 10 2023, 18:55
Closed by commit rABC0e9ca4eec6be: [herald] Refactor handleBlockConnected to support multiple api calls later (authored by bytesofman). · Explain WhyApr 12 2023, 14:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC0e9ca4eec6be: [herald] Refactor handleBlockConnected to support multiple api calls later.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
src/
43 lines

Diff 39497

View Options

apps/ecash-herald/src/events.js

Loading...