Differential D13834

[explorer] Lint the explorer
ClosedPublic
Actions

Authored by Fabien on May 1 2023, 13:21.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCa4d202e5af50: [explorer] Lint the explorer

Summary

This undo some of the formatting from older prettier versions.

Test Plan

arc lint -- web/explorer/explorer-server/templates/pages/*

Check your linter agrees with mine.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

lint_html

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23596
Build 46806: Build Diff
Build 46805: arc lint + arc unit

Event Timeline

Fabien created this revision.May 1 2023, 13:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2023, 13:21

Fabien requested review of this revision.May 1 2023, 13:21

Harbormaster completed remote builds in B23580: Diff 40113.May 1 2023, 13:21

arc patch 13834
arc lint

It reverts this change

Auto-Fix  (PRETTIER) Code style violation
   '~/bitcoin-abc/web/explorer/explorer-server/templates/pages/address.html'
   has code style errors.

            162 
            163             <table
            164                 id="address-txs-table"
   >>> -    165                 class="
       -    166                     block-listing__datatable
       -    167                     dataTable
       -    168                     compact
       -    169                     responsive
       -    170                     nowrap
       -    171                     no-footer
       -    172                 "
       +                        class="block-listing__datatable dataTable compact responsive nowrap no-footer"
            173                 style="width: 100%"
            174             >
            175                 <thead>
            176                     <tr>
OKAY  No lint messages.

I'm on

$ prettier -v
2.6.0

In D13834#308342, @bytesofman wrote:

arc patch 13834
arc lint

It reverts this change

Auto-Fix  (PRETTIER) Code style violation
   '~/bitcoin-abc/web/explorer/explorer-server/templates/pages/address.html'
   has code style errors.

            162 
            163             <table
            164                 id="address-txs-table"
   >>> -    165                 class="
       -    166                     block-listing__datatable
       -    167                     dataTable
       -    168                     compact
       -    169                     responsive
       -    170                     nowrap
       -    171                     no-footer
       -    172                 "
       +                        class="block-listing__datatable dataTable compact responsive nowrap no-footer"
            173                 style="width: 100%"
            174             >
            175                 <thead>
            176                     <tr>
OKAY  No lint messages.

I'm on