Page MenuHomePhabricator

Add gitian-sigs path and description to use it
AbandonedPublic

Authored by jasonbcox on May 30 2018, 03:01.

Details

Reviewers
schancel
matiu
Group Reviewers
Restricted Project
Summary

This add the path /contrib/gitian-sigs that will contains
contributor's gitian asserts and signatures to ease the process
of comparing gitian builds among contributors.

A Readme file is included to describe its usage.

As a bootstrap, 2 files (an assert and its signatures) are included for the upcoming v0.17.2 version

Test Plan

-

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gitian-sigs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2693
Build 3498: Bitcoin ABC Buildbot (legacy)
Build 3497: arc lint + arc unit

Event Timeline

Add osx builds asserts + sig

Do the assert.sig files need to be in ASCII format just like our keys do?

I don't think it makes a lot of sens to have this under source control.

schancel added inline comments.
contrib/gitian-sigs/Readme.md
18 ↗(On Diff #4029)

What occurs here that the github username is used? Seems like it should be a gpg email attached to your key?

46 ↗(On Diff #4029)

What is this gverify thing? Is this part of gitian?

I don't think it makes a lot of sens to have this under source control.

Should we have it on a new repo? Do you want me to set up a new repo in my user so we can test it, and if makes sense we can move it to bitcoin-abc user?

contrib/gitian-sigs/Readme.md
18 ↗(On Diff #4029)

it is your github user name. What ever github user you are using now.

contrib/gitian-sigs/Readme.md
18 ↗(On Diff #4029)

This is a true statement. *Why* is it my github username?

contrib/gitian-sigs/Readme.md
31 ↗(On Diff #4029)

Is it intentional to switch to $USER here from $GUSER?

schancel requested changes to this revision.Jun 4 2018, 14:34
This revision now requires changes to proceed.Jun 4 2018, 14:34
contrib/gitian-sigs/Readme.md
12 ↗(On Diff #4029)

I'm not sure how to do this on vagrant. Please include instructions on how that's done. My shallow understanding is there's a shared directory where you can put the key file, but I'm not sure which.

matiu marked 2 inline comments as done.

update doc $USER variable

schancel requested changes to this revision.Jun 18 2018, 12:48

We had discussed out of band that you were going to fix the "Readme.md" file to be a proper MD file. I am requesting those changes here.

This revision now requires changes to proceed.Jun 18 2018, 12:48
matiu marked 2 inline comments as done.

Update format of Readme.md to match MarkDown

We had discussed out of band that you were going to fix the "Readme.md" file to be a proper MD file. I am requesting those changes here.

thanks. updated.

contrib/gitian-sigs/Readme.md
12 ↗(On Diff #4029)

You just need to run gpg --import < key_file on the virtual box. The keys will be stored somewhere inside ~/.gnpg.

key_file's contents can be scp or copy and pasted to the virtual box from the key machine.

18 ↗(On Diff #4029)

The string you put there is the name of the path that will be created with your assert + signature.

It seems most people use the GitHub name, to simplify the identification of the builds.

The signature contains the key id that was used to sign it, and the person verifying the signature need to have imported the matching public key before hand. It doesn't have to match the github user name

31 ↗(On Diff #4029)

thanks. updated.

46 ↗(On Diff #4029)

it will check you build against other builders, it is a gitian feature already there.

It is the same we do it manually on slack, but better.

contrib/gitian-sigs/Readme.md
12 ↗(On Diff #4029)

I understand the first part, but it's not clear to me how to scp to a local vagrant box. Is there a default server to scp to/from? It looks like there's a pluging to do it: https://github.com/invernizzi/vagrant-scp but we don't have this plugin as part of our dev process as far as I know.

contrib/gitian-sigs/Readme.md
64 ↗(On Diff #4139)

Does the NFS mounts I have been using not work for you?

schancel requested changes to this revision.Jul 12 2018, 18:20
This revision now requires changes to proceed.Jul 12 2018, 18:20
jasonbcox abandoned this revision.
jasonbcox added a reviewer: matiu.