Page MenuHomePhabricator
Differential D13982

[Chronik] Add `broadcast_tx` to `ChronikBridge`
ClosedPublic
Actions

Authored by tobias_ruck on Jun 4 2023, 22:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5d5dc8b4cca9: [Chronik] Add `broadcast_tx` to `ChronikBridge`
Summary

Allows us to broadcast txs from Chronik.

Use node::BroadcastTransaction internally.

Depends on D13980.

Test Plan

ninja test_bitcoin && ./src/test/test_bitcoin -t chronikbridge_tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-broadcast_tx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23898
Build 47406: Build Diffbuild-chronik
Build 47405: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jun 4 2023, 22:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2023, 22:09
tobias_ruck requested review of this revision.Jun 4 2023, 22:09
Harbormaster completed remote builds in B23894: Diff 40582.Jun 4 2023, 22:29
Fabien requested changes to this revision.Jun 5 2023, 08:37
Fabien added inline comments.
chronik/chronik-cpp/chronik_bridge.cpp
241 ↗(On Diff #40582)

Use MakeTransactionRef(tx) instead

This revision now requires changes to proceed.Jun 5 2023, 08:37
tobias_ruck updated this revision to Diff 40589.Jun 5 2023, 09:49

Use MakeTransactionRef, fix comment spelling

Harbormaster completed remote builds in B23898: Diff 40589.Jun 5 2023, 10:32
Fabien accepted this revision.Jun 5 2023, 11:51
This revision is now accepted and ready to land.Jun 5 2023, 11:51
Closed by commit rABC5d5dc8b4cca9: [Chronik] Add `broadcast_tx` to `ChronikBridge` (authored by tobias_ruck). · Explain WhyJun 5 2023, 12:37
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC5d5dc8b4cca9: [Chronik] Add `broadcast_tx` to `ChronikBridge`.

Revision Contents
Changeset List

PathSize
chronik/
chronik-bridge/
src/
10 lines
chronik-cpp/
3 lines
26 lines
test/
70 lines

Diff 40589

View Options

chronik/chronik-bridge/src/ffi.rs

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.h

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.cpp

Loading...
View Options

chronik/test/chronikbridge_tests.cpp

Loading...