Page MenuHomePhabricator
Differential D1483

Remove monolith activation altogether
ClosedPublic
Actions

Authored by deadalnix on Jun 6 2018, 20:18.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING6c61ac4c1c31: Remove monolith activation altogether
rABC6c61ac4c1c31: Remove monolith activation altogether
Summary

Monolith was purely additive. Now that it is activated, we can consider it as it if always was activated.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
monolithcleanup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2712
Build 3536: Bitcoin ABC Buildbot (legacy)
Build 3535: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 6 2018, 20:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2018, 20:18
teamcity added a subscriber: teamcity.Jun 6 2018, 20:20

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 6 2018, 20:53

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2709: Diff 4076.Jun 6 2018, 20:53
jasonbcox requested changes to this revision.Jun 6 2018, 23:21
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/abc-p2p-fullblocktest.py
50 ↗(On Diff #4076)

Doesn't this need to be cleaned up as well?

68 ↗(On Diff #4076)

And here.

This revision now requires changes to proceed.Jun 6 2018, 23:21
deadalnix added a comment.Jun 6 2018, 23:42

Yes, this doesn't cleanup everything, just the core logic.

deadalnix updated this revision to Diff 4079.Jun 7 2018, 00:15

Complete cleanup

teamcity added a comment.Jun 7 2018, 00:17

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 7 2018, 00:52

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2712: Diff 4079.Jun 7 2018, 00:52
jasonbcox accepted this revision.Jun 7 2018, 22:33
This revision is now accepted and ready to land.Jun 7 2018, 22:33
Closed by commit rABC6c61ac4c1c31: Remove monolith activation altogether (authored by deadalnix). · Explain WhyJun 8 2018, 14:53
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
9 lines
consensus/
2 lines
7 lines
test/
27 lines
3 lines
35 lines
test/
functional/
16 lines
46 lines
2 lines

Diff 4079

View Options

src/chainparams.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-monolith-activation.py

Loading...
View Options

test/functional/abc-p2p-compactblocks.py

Loading...
View Options

test/functional/abc-p2p-fullblocktest.py

Loading...
View Options

test/functional/mempool_reorg.py

Loading...