[Cashtab] Move explorer config out of Ticker
ClosedPublic
Actions

Authored by emack on Jun 25 2023, 14:21.

Details

Reviewers

bytesofman
Fabien

Group Reviewers

Restricted Project

Commits

rABC71eba14561f4: [Cashtab] Move explorer config out of Ticker

Summary

Moving the explorer related params out of Ticker.js and into its own config file.

Test Plan

grep -r currency.blockExplorerUrl src/
grep -r currency.blockExplorerUrlTestnet src/
grep -r currency.pdfReceiptUrl src/
npm test
npm start
click on any transaction in the Tx History tab and then click the View on e.cash link and ensure the appropriate tx is displayed in explorer.e.cash
click on any transaction in the Tx History tab and then click the Receipt links and ensure a Blockchair powered transaction receipt PDF is displayed

Diff Detail

Repository

rABC Bitcoin ABC

Branch

explorer_config

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24173
Build 47956: Build Diff	cashtab-tests
Build 47955: arc lint + arc unit

Event Timeline

emack created this revision.Jun 25 2023, 14:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 25 2023, 14:21

emack requested review of this revision.Jun 25 2023, 14:21

Harbormaster completed remote builds in B24168: Diff 40978.Jun 25 2023, 14:24

Fabien requested changes to this revision.Jun 25 2023, 18:31

Fabien added a subscriber: Fabien.

Fabien added inline comments.

cashtab/src/components/Home/Tx.js
25 ↗	(On Diff #40978)	I aliased chronik as chronikConfig because the name chronik was already used to hold the ChronikClient handle, which makes sense. I don't think there is an explorer variable anywhere in the codebase that requires you to create this alias.