Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6a9960754043: [electrum] document the release procedure

Summary

As per title

Test Plan

Go through all the steps.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

electrum_release_doc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24225
Build 48060: Build Diff
Build 48059: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 28 2023, 07:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2023, 07:06

PiRK requested review of this revision.Jun 28 2023, 07:06

Harbormaster completed remote builds in B24223: Diff 41058.Jun 28 2023, 07:06

updates in the update_checker README.md doc

Harbormaster completed remote builds in B24224: Diff 41060.Jun 28 2023, 07:14

fixup python package name

Harbormaster completed remote builds in B24225: Diff 41061.Jun 28 2023, 07:15

Note that the OSX build script still relies on tags to find the version for the dmg filename, so it finds the Bitcoin ABC version. This will be fixed in a separate diff, and for this release I will manually fix the filename (the application itself uses the correct version from version.py)

Fabien requested changes to this revision.Jun 28 2023, 07:24

Fabien added a subscriber: Fabien.

Fabien added inline comments.

electrum/contrib/release.md
1	You're missing a title instead of this blank line
18	Do we need the latest docker version or is this an artifact from an old document ? Because docker is packaged in debian/ubuntu already
35	Also from outside the electrum directory ? like node files ?

This revision now requires changes to proceed.Jun 28 2023, 07:24

add paragraph about bumping the version and chekcing release notes

Harbormaster completed remote builds in B24226: Diff 41063.Jun 28 2023, 07:28

PiRK added inline comments.Jun 28 2023, 07:30

electrum/contrib/release.md
35	yes. The script is currently doing: git clean -xdff \ --exclude=contrib/osx/.cache \ -- .

PiRK added inline comments.Jun 28 2023, 07:33

electrum/contrib/release.md
35	Actually no, it only cleans the electrum folder. Great. Will update this comment.

add title, indent other headers accordingly, simplify the docker notes, fix the comment about make_clean (only the electrum directory is cleaned), remove unnecessary comment about the DMG not being code signed (this is already mentioned in contrib/osx/README.md)

Harbormaster completed remote builds in B24227: Diff 41065.Jun 28 2023, 07:58

bytesofman added a subscriber: bytesofman.Jun 28 2023, 13:28

bytesofman added inline comments.