Page MenuHomePhabricator
Differential D14189

[Cashtab][Alias] Implement getAliasesForAddress
ClosedPublic
Actions

Authored by emack on Jul 2 2023, 00:28.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC6720c88e2e55: [Cashtab][Alias] Implement getAliasesForAddress
Summary

T3216

Add the new getAliasesForAddress function in aliasUtils.js to wrap around the fetch call to alias-server's address endpoint.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getAliases
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24317
Build 48244: Build Diffcashtab-tests
Build 48243: arc lint + arc unit

Event Timeline

emack created this revision.Jul 2 2023, 00:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2023, 00:28
emack requested review of this revision.Jul 2 2023, 00:28
Harbormaster completed remote builds in B24300: Diff 41169.Jul 2 2023, 00:28
emack planned changes to this revision.Jul 2 2023, 00:31
emack updated this revision to Diff 41170.Jul 2 2023, 00:40

globalized the fetch() mock override, fixed linting and unit test issues

Harbormaster completed remote builds in B24301: Diff 41170.Jul 2 2023, 00:43
bytesofman requested changes to this revision.Jul 2 2023, 03:20
bytesofman added inline comments.
cashtab/src/utils/__mocks__/mockAliasServerResposnes.js
1 ↗(On Diff #41170)
cashtab/src/utils/__tests__/aliasUtils.test.js
7 ↗(On Diff #41170)
47 ↗(On Diff #41170)

should be getting an error here

This revision now requires changes to proceed.Jul 2 2023, 03:20
emack mentioned this in D14193: [alias-server] Error response handling patch.Jul 2 2023, 09:02
emack updated this revision to Diff 41185.Jul 2 2023, 09:17
emack marked 2 inline comments as done.

fixed typos

emack planned changes to this revision.Jul 2 2023, 09:17
emack added inline comments.
cashtab/src/utils/__tests__/aliasUtils.test.js
48 ↗(On Diff #41185)

Will update response handling once D14193 is propagated to alias.etokens.cash.

Harbormaster completed remote builds in B24311: Diff 41185.Jul 2 2023, 09:20
emack mentioned this in rABC366a96823508: [alias-server] Error response handling patch.Jul 2 2023, 13:49
emack updated this revision to Diff 41200.Jul 3 2023, 02:01

updated getAliasesforAddress to throw error if address endpoint returns an error response
updated error handling unit test accordingly

Harbormaster completed remote builds in B24317: Diff 41200.Jul 3 2023, 02:05
bytesofman accepted this revision.Jul 3 2023, 03:51
This revision is now accepted and ready to land.Jul 3 2023, 03:51
Closed by commit rABC6720c88e2e55: [Cashtab][Alias] Implement getAliasesForAddress (authored by emack). · Explain WhyJul 3 2023, 14:44
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABC6720c88e2e55: [Cashtab][Alias] Implement getAliasesForAddress.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Common/
2 lines
utils/
__mocks__/
44 lines
__tests__/
57 lines
31 lines

Diff 41200

View Options

cashtab/src/components/Common/Ticker.js

Loading...
View Options

cashtab/src/utils/__mocks__/mockAliasServerResponses.js

Loading...
View Options

cashtab/src/utils/__tests__/aliasUtils.test.js

Loading...
View Options

cashtab/src/utils/aliasUtils.js

Loading...