Page MenuHomePhabricator

[Cashtab][Alias] Deprecate alias caching mechanism
ClosedPublic

Authored by emack on Jul 29 2023, 05:57.

Details

Summary

T3216

Depends on D14322

All component dependencies on the previous alias caching mechanism have now been deprecated. This diff removes the remaining un-used alias caching logic and unit tests.

Test Plan
  • grep -r aliasCache src/
  • grep -r getAliasesFromLocalForage src/
  • npm test
  • set alias flag to true in Ticker.js
  • npm start
  • open an existing wallet with the previous aliasCache in localForage and ensure no caching errors in the console log (simulating the majority of current users)
  • delete cashtabCache in localForage, reload Cashtab and note the cashtabCache successfully updated message in the console log, along with no sign of aliasCache object in cashtabCache
  • verify tokenInfoById in cashtabCache is correctly populated with tokens held by the wallet
  • create a new wallet, observe no caching errors in console log and no aliasCache object in cashtabCache
  • import a wallet, observe no caching errors in console log and correct cashtabCache structure
  • set the alias flag set to false in Ticker.js and reload Cashtab and ensure no caching errors in console log

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getAddressFromAliasDep
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24620
Build 48837: Build Diffcashtab-tests
Build 48836: arc lint + arc unit

Event Timeline

emack requested review of this revision.Jul 29 2023, 05:57
This revision is now accepted and ready to land.Jul 29 2023, 14:36

Double checking with Joey on any caching related edge cases previously encountered during wallet cache migrations before landing this

having issues patching this in, is this + the diff under it rebased to the latest master?