[Cashtab][Alias] Add chronik mock
ClosedPublic
Actions

Authored by emack on Jul 31 2023, 23:07.

Details

Reviewers

bytesofman
Fabien

Group Reviewers

Restricted Project

Commits

rABC144e5d653d92: [Cashtab][Alias] Add chronik mock

Summary

T3216

This diff separates out the chronik mock from D14325 and updates the registerNewAlias unit tests to be ready for websocket behaviors in D14325.

Test Plan

npm test

Repository

rABC Bitcoin ABC

Branch

chronikMock

Lint

Lint Passed

Unit

No Test Coverage

Build Status

emack requested review of this revision.Jul 31 2023, 23:07

bytesofman requested changes to this revision.Jul 31 2023, 23:20

bytesofman added inline comments.

cashtab/src/utils/__mocks__/chronikMock.js
8	limit the logic added here to only what you need for the websocket tests we have a lot of chronik unit tests in cashtab that should use the mock. Understandably beyond the scope of this diff. difficult to review the mock when it's just dumped in and not implemented. Can add to this as its implemented in other existing unit tests.

This revision now requires changes to proceed.Jul 31 2023, 23:20

Limiting chronik mock to broadcastTx and websocket logic

bytesofman requested changes to this revision.Jul 31 2023, 23:37

bytesofman added inline comments.

cashtab/src/utils/__tests__/transactions.test.js
116 ↗	(On Diff #41656)	why mock this with jest? you have included this method in MockChronikClient, where it can be set by the `setMock` method If jest is a better way to do it in Cashtab, don't include these methods in the mock