Page MenuHomePhabricator
Differential D14201

[alias-server] Support for pending alias txs
ClosedPublic
Actions

Authored by bytesofman on Jul 3 2023, 22:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC860a2c06d709: [alias-server] Support for pending alias txs
Summary

T3060

Support for adding and removing pending aliases from a dedicated pending aliases collection

Caching is introduced so that tipHeight is available inside the added to mempool event. It would be available from serverState in the database, but deemed impractical to make a database call on every incoming tx (could be a huge throughput of these) for a value that only changes every 10 minutes on avg.

pending alias registrations that become valid alias registrations are removed from the cache.

pending aliases are added to the cache on app startup.

pending aliases that go more than 6 confirmations without becoming confirmed or otherwise cleaned up are dropped from the pending collection to prevent unbounded growth.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pending-support-alias-server
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24785
Build 49162: Build Diffalias-server-tests
Build 49161: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
teamcity added a comment.Aug 23 2023, 04:06
Build Bitcoin ABC Diffs / Diff Testing (alias-server-tests) failed.

Tail of the build log:

    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Module.require (node:internal/modules/cjs/loader:1100:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/work/apps/alias-server/src/alias.js:5:365)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Module.require (node:internal/modules/cjs/loader:1100:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/work/apps/alias-server/test/aliasTests.js:15:5)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:438:15)
    at async formattedImport (/work/apps/alias-server/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
    at async Object.exports.requireOrImport (/work/apps/alias-server/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
    at async Object.exports.loadFilesAsync (/work/apps/alias-server/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/work/apps/alias-server/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async Object.exports.handler (/work/apps/alias-server/node_modules/mocha/lib/cli/run.js:370:5)
------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------------------|---------|----------|---------|---------|-------------------
All files               |    6.31 |        0 |       0 |    6.48 |                   
 alias-server           |     100 |      100 |     100 |     100 |                   
  config.js             |     100 |      100 |     100 |     100 |                   
 alias-server/constants |     100 |      100 |     100 |     100 |                   
  alias.js              |     100 |      100 |     100 |     100 |                   
 alias-server/src       |    5.61 |        0 |       0 |    5.76 |                   
  alias.js              |    4.81 |        0 |       0 |       5 | 14-296            
  db.js                 |    5.88 |        0 |       0 |    5.94 | 12-342            
  rpc.js                |    8.33 |        0 |       0 |    8.33 | 10-105            
  utils.js              |    5.17 |        0 |       0 |    5.45 | 12-152            
------------------------|---------|----------|---------|---------|-------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='17']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='269']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='119']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='30']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='17']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='262']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/alias-server-junit.xml': No such file or directory
Build alias-server-tests failed with exit code 1
Fabien requested changes to this revision.Aug 23 2023, 08:21

This doesn't work. There is no way you can tell if the node is lacking the tx or if it has been removed. Just handle the removed from mempool event, that's it.

This revision now requires changes to proceed.Aug 23 2023, 08:21
bytesofman updated this revision to Diff 41907.Aug 23 2023, 12:55

handle RemovedFromMempool event

Harbormaster completed remote builds in B24826: Diff 41907.Aug 23 2023, 12:55
bytesofman updated this revision to Diff 41908.Aug 23 2023, 12:56

lint

teamcity added a comment.Aug 23 2023, 12:57
Build Bitcoin ABC Diffs / Diff Testing (alias-server-tests) failed.

Tail of the build log:

    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Module.require (node:internal/modules/cjs/loader:1100:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/work/apps/alias-server/src/alias.js:5:365)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Module.require (node:internal/modules/cjs/loader:1100:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/work/apps/alias-server/test/aliasTests.js:15:5)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:438:15)
    at async formattedImport (/work/apps/alias-server/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
    at async Object.exports.requireOrImport (/work/apps/alias-server/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
    at async Object.exports.loadFilesAsync (/work/apps/alias-server/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/work/apps/alias-server/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async Object.exports.handler (/work/apps/alias-server/node_modules/mocha/lib/cli/run.js:370:5)
------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------------------|---------|----------|---------|---------|-------------------
All files               |    6.31 |        0 |       0 |    6.48 |                   
 alias-server           |     100 |      100 |     100 |     100 |                   
  config.js             |     100 |      100 |     100 |     100 |                   
 alias-server/constants |     100 |      100 |     100 |     100 |                   
  alias.js              |     100 |      100 |     100 |     100 |                   
 alias-server/src       |    5.61 |        0 |       0 |    5.76 |                   
  alias.js              |    4.81 |        0 |       0 |       5 | 14-296            
  db.js                 |    5.88 |        0 |       0 |    5.94 | 12-342            
  rpc.js                |    8.33 |        0 |       0 |    8.33 | 10-105            
  utils.js              |    5.17 |        0 |       0 |    5.45 | 12-152            
------------------------|---------|----------|---------|---------|-------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='17']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='269']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='119']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='30']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='17']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='262']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/alias-server-junit.xml': No such file or directory
Build alias-server-tests failed with exit code 1
Harbormaster completed remote builds in B24827: Diff 41908.Aug 23 2023, 12:58
teamcity added a comment.Aug 23 2023, 12:58
Build Bitcoin ABC Diffs / Diff Testing (alias-server-tests) failed.

Tail of the build log:

    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Module.require (node:internal/modules/cjs/loader:1100:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/work/apps/alias-server/src/alias.js:5:365)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Module.require (node:internal/modules/cjs/loader:1100:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/work/apps/alias-server/test/aliasTests.js:15:5)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:438:15)
    at async formattedImport (/work/apps/alias-server/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
    at async Object.exports.requireOrImport (/work/apps/alias-server/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
    at async Object.exports.loadFilesAsync (/work/apps/alias-server/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/work/apps/alias-server/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async Object.exports.handler (/work/apps/alias-server/node_modules/mocha/lib/cli/run.js:370:5)
------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------------------|---------|----------|---------|---------|-------------------
All files               |    6.31 |        0 |       0 |    6.48 |                   
 alias-server           |     100 |      100 |     100 |     100 |                   
  config.js             |     100 |      100 |     100 |     100 |                   
 alias-server/constants |     100 |      100 |     100 |     100 |                   
  alias.js              |     100 |      100 |     100 |     100 |                   
 alias-server/src       |    5.61 |        0 |       0 |    5.76 |                   
  alias.js              |    4.81 |        0 |       0 |       5 | 14-296            
  db.js                 |    5.88 |        0 |       0 |    5.94 | 12-342            
  rpc.js                |    8.33 |        0 |       0 |    8.33 | 10-105            
  utils.js              |    5.17 |        0 |       0 |    5.45 | 12-152            
------------------------|---------|----------|---------|---------|-------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='17']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='269']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='119']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='30']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='17']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='262']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/alias-server-junit.xml': No such file or directory
Build alias-server-tests failed with exit code 1
bytesofman added a comment.Aug 23 2023, 13:00
In D14201#322984, @Fabien wrote:

This doesn't work. There is no way you can tell if the node is lacking the tx or if it has been removed. Just handle the removed from mempool event, that's it.

The websocket connection can't be treated as 100% reliable, as it will frequently disconnect and reconnect, occasionally missing events.

This is acceptable for the BlockConnected event -- as the app will eventually get a confirmed block, and, if it missed earlier blocks, catch up by processing those txs.

With RemovedFromMempool -- if the app misses the msg, it will never get it again. So, there needs to be some sort of fallback.

In this case, isNotInMempool is only being called on a txid that has already been seen once in the mempool -- so we know the node is not lacking the tx.

bytesofman updated this revision to Diff 41909.Aug 23 2023, 13:08

Refactor to use sample secrets in failing CI unit test

Harbormaster completed remote builds in B24828: Diff 41909.Aug 23 2023, 13:10
Fabien requested changes to this revision.Aug 24 2023, 12:52
In D14201#323007, @bytesofman wrote:
In D14201#322984, @Fabien wrote:

This doesn't work. There is no way you can tell if the node is lacking the tx or if it has been removed. Just handle the removed from mempool event, that's it.

The websocket connection can't be treated as 100% reliable, as it will frequently disconnect and reconnect, occasionally missing events.

This is acceptable for the BlockConnected event -- as the app will eventually get a confirmed block, and, if it missed earlier blocks, catch up by processing those txs.

With RemovedFromMempool -- if the app misses the msg, it will never get it again. So, there needs to be some sort of fallback.

I'm ok with some periodic cleanup to recover from this kind of issue, but this is just not a right way to do it.

In this case, isNotInMempool is only being called on a txid that has already been seen once in the mempool -- so we know the node is not lacking the tx.

That is wrong. There is no guarantee that chronik is using the same node as your call (in fact it's unlikely to be the case) so discrepeancy is to be expected.
Really there is no point in reading the mempool anyway: if a tx was not confirmed after x blocks, just remove it from the pending list: there is something wrong with that tx.

This revision now requires changes to proceed.Aug 24 2023, 12:52
bytesofman updated this revision to Diff 41952.Aug 25 2023, 18:33

remove mempool check, add increment function and 'missedConfirmations' key to pendingAlias objects

Harbormaster completed remote builds in B24859: Diff 41952.Aug 25 2023, 18:33
bytesofman updated this revision to Diff 41953.Aug 25 2023, 18:34

lint

Harbormaster completed remote builds in B24860: Diff 41953.Aug 25 2023, 18:34
bytesofman updated this revision to Diff 41954.Aug 25 2023, 18:35

lint and remove debug logging

Harbormaster completed remote builds in B24861: Diff 41954.Aug 25 2023, 18:36
bytesofman updated this revision to Diff 41955.Aug 25 2023, 18:38

Improve comments

Harbormaster completed remote builds in B24862: Diff 41955.Aug 25 2023, 18:39
bytesofman planned changes to this revision.Aug 25 2023, 22:20

Improve efficiency here

  • Lose the age in ms check
  • Save pendingAliases with a tipheight, then filtered delete for > 10 blocks from tipHeight
bytesofman updated this revision to Diff 42093.Sep 6 2023, 19:38

Using redis to store pending aliases in cache, not database.

Harbormaster completed remote builds in B24962: Diff 42093.Sep 6 2023, 19:38
bytesofman updated this revision to Diff 42094.Sep 6 2023, 19:39

lint

bytesofman edited the summary of this revision. (Show Details)Sep 6 2023, 19:40
bytesofman planned changes to this revision.Sep 6 2023, 19:46

need to clean up, review, add a unit test

bytesofman updated this revision to Diff 42095.Sep 6 2023, 19:54

unit test for tx history provided to handle mempool, remove debug logging, better code comments

teamcity added a comment.Sep 6 2023, 20:39
Build Bitcoin ABC Diffs / Diff Testing (alias-server-tests) failed.

Tail of the build log:

  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Build alias-server-tests timed out after 3600.0s
Harbormaster completed remote builds in B24963: Diff 42094.Sep 6 2023, 20:40
teamcity added a comment.Sep 6 2023, 20:40
Build Bitcoin ABC Diffs / Diff Testing (alias-server-tests) failed.

Tail of the build log:

  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Build alias-server-tests timed out after 3600.0s
Harbormaster completed remote builds in B24964: Diff 42095.Sep 6 2023, 20:55
teamcity added a comment.Sep 6 2023, 20:55
Build Bitcoin ABC Diffs / Diff Testing (alias-server-tests) failed.

Tail of the build log:

  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Redis Client Error Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 6379
}
Build alias-server-tests timed out after 3600.0s
bytesofman planned changes to this revision.Sep 6 2023, 22:36

need to address redis in unit testing CI

bytesofman updated this revision to Diff 42116.Sep 7 2023, 18:26

Mock redis for CI unit tests

Harbormaster completed remote builds in B24976: Diff 42116.Sep 7 2023, 18:27
bytesofman updated this revision to Diff 42117.Sep 7 2023, 18:29

Add README to mock-redis

Harbormaster completed remote builds in B24977: Diff 42117.Sep 7 2023, 18:30
Fabien requested changes to this revision.Sep 8 2023, 08:43

It costs about 60$ to crash the server.

This revision now requires changes to proceed.Sep 8 2023, 08:43
bytesofman planned changes to this revision.Sep 8 2023, 18:29

need to handle removed from mempool event

bytesofman updated this revision to Diff 42143.Sep 11 2023, 23:52

reverting to mongodb with ttl to handle mempool drops

bytesofman planned changes to this revision.Sep 11 2023, 23:53

needs more testing, need to review this myself and clean up

Harbormaster completed remote builds in B24996: Diff 42143.Sep 11 2023, 23:56
bytesofman updated this revision to Diff 42162.Sep 12 2023, 21:48

implement caching for tipheight, mongo ttl will not work for compound index, which is needed

Harbormaster completed remote builds in B25005: Diff 42162.Sep 12 2023, 21:48
bytesofman updated this revision to Diff 42163.Sep 12 2023, 21:49

lint

bytesofman planned changes to this revision.Sep 12 2023, 21:49

need to self review and run more tests

Harbormaster completed remote builds in B25006: Diff 42163.Sep 12 2023, 21:50
bytesofman updated this revision to Diff 42164.Sep 12 2023, 22:10

Clean up comments, remove changes unrelated to diff

apps/alias-server/test/chronikWsHandlerTests.js
13 ↗(On Diff #42163)

still pending a one-off diff to move all apps using local chronik-client over to this one. need to make this change here bc the local copy doesn't have the .tx mock feature, but the master one does.

Harbormaster completed remote builds in B25007: Diff 42164.Sep 12 2023, 22:11
Fabien requested changes to this revision.Sep 13 2023, 07:56
Fabien added inline comments.
apps/alias-server/src/db.js
275 ↗(On Diff #42164)

It's no longer using redis (good thing), so you need to update the summary

305 ↗(On Diff #42164)

I don't think this is ever going to be useful outside of the tests ? If I'm right you'd better implement getPendingAliasesForAddress() directly, as you can use it the same way in the tests.

This revision now requires changes to proceed.Sep 13 2023, 07:56
bytesofman edited the summary of this revision. (Show Details)Sep 13 2023, 16:19
bytesofman updated this revision to Diff 42175.Sep 13 2023, 16:26
bytesofman marked an inline comment as done.

Modify getPendingAliases function to accept mongodb selection filter

bytesofman marked an inline comment as done.Sep 13 2023, 16:28
bytesofman added inline comments.
apps/alias-server/src/db.js
305 ↗(On Diff #42164)

In this diff, no -- but the function will be used when we set up the API.

Will include unit tests for those cases in that diff.

Keeping it open to specific queries as could be useful to know all pending aliases, though I would not want it to be in a public API endpoint.

Harbormaster completed remote builds in B25014: Diff 42175.Sep 13 2023, 16:33
Fabien accepted this revision.Sep 14 2023, 12:51
This revision is now accepted and ready to land.Sep 14 2023, 12:51
Closed by commit rABC860a2c06d709: [alias-server] Support for pending alias txs (authored by bytesofman). · Explain WhySep 14 2023, 17:07
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.
bytesofman added a commit: rABC860a2c06d709: [alias-server] Support for pending alias txs.

Revision Contents
Changeset List

PathSize
apps/
alias-server/
src/
4 lines
65 lines
87 lines
test/
82 lines
238 lines
233 lines
mocks/
10 lines

Diff 41844

View Options

apps/alias-server/src/chronikWsHandler.js

Loading...
View Options

apps/alias-server/src/db.js

Loading...
View Options

apps/alias-server/src/events.js

Loading...
View Options

apps/alias-server/test/chronikWsHandlerTests.js

Loading...
View Options

apps/alias-server/test/dbTests.js

Loading...
View Options

apps/alias-server/test/eventsTests.js

Loading...
View Options

apps/alias-server/test/mocks/chronikMock.js

Loading...