Page MenuHomePhabricator

[chronik] Keep required Rust version in one place
ClosedPublic

Authored by osoftware on Aug 14 2023, 19:09.

Details

Reviewers
tobias_ruck
Fabien
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rABCb5a49c46dc7d: [chronik] Keep required Rust version in one place
Summary

Set required Rust version on the workspace level and inherit that in all packages.

Test Plan

mkdir buildChronik && cd buildChronik
cmake -GNinja .. -DBUILD_BITCOIN_CHRONIK=ON
ninja all check-crates
./test/functional/test_runner.py chronik_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24795
Build 49182: Build Diffbuild-chronik
Build 49181: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 14 2023, 19:09
Fabien requested changes to this revision.Aug 15 2023, 11:07
Fabien added a subscriber: Fabien.

Please also align the version in bitcoinsuite-core, bitcoinsuite-slp and chronik-bridge Cargo.toml files. After that we should try to have all this in a single place

This revision now requires changes to proceed.Aug 15 2023, 11:07

Updating D14378: [chronik] Bump Rust version check in Chronik build

Keep required Rust version in one place

Updating D14378: [chronik] Bump Rust version check in Chronik build

This revision is now accepted and ready to land.Aug 16 2023, 19:32

Can you update the title + commit message? The deeper telos now is to move the version to one place, not to set them to the same version (which is a nice side effect now). Otherwise good work

This revision now requires changes to proceed.Aug 16 2023, 20:37
osoftware retitled this revision from [chronik] Bump Rust version check in Chronik build to [chronik] Keep required Rust version in one place.Aug 18 2023, 20:49
osoftware edited the summary of this revision. (Show Details)
osoftware edited the test plan for this revision. (Show Details)

Updating D14378: Rephrasing commit messages

This revision is now accepted and ready to land.Aug 18 2023, 21:02