Page MenuHomePhabricator
Differential D14524

[electrum] store and serialize tx data as bytes
ClosedPublic
Actions

Authored by PiRK on Sep 22 2023, 13:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0c195f354aa5: [electrum] store and serialize tx data as bytes
Summary

This should reduce the memory usage of the application by dividing the size of unserialized transactions by 2, and saves a bytes.fromhex(..) conversion in the deserialization function.
The bytes.fromhex conversion now happens at the I/O layer (opening wallet files, receiving transactions from the network, copy-pasting unsigned hex transactions), where the conversion cost probably does not make a difference as the process is I/O bound.

Depends on D14525

Test Plan

python test_runner.py

./electrum-abc deserialize 02000000012367ad0da9fb8f8a7e574d55d4eb2dd0fd8ebd58b1c21cfddb9fe5426369082a000000006441761c8b702e06fcb8656cb205454f22efff174e3ae9552c1ee83f7d64e3b0d29fa466c48a82597713fd7a3c03e324855349a76660fa26dfec4922c51ea0f51cb6412102a42cd220e6099d5d678066b81813ae4fdd14b290479962ae5c0af1448113bcb4feffffff030000000000000000066a047370616d05b20100000000001976a9144fe822f96257d66eeb498394ce9a1fbca1323ba088ac10270000000000001976a914b97b77f0a2e0b3161354de723a76d58a974c601988ac00000000

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tx_rax_bytes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25137
Build 49862: Build Diffelectrum-tests
Build 49861: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 22 2023, 13:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2023, 13:00
Harbormaster completed remote builds in B25131: Diff 42342.Sep 22 2023, 13:02
PiRK updated this revision to Diff 42346.Sep 22 2023, 14:39
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D14525: [electrum] consolidate compact_size code.

rebase ont D14525

Harbormaster completed remote builds in B25135: Diff 42346.Sep 22 2023, 14:40
PiRK updated this revision to Diff 42347.Sep 22 2023, 14:53

remove low-priority and low impact todos

Harbormaster completed remote builds in B25136: Diff 42347.Sep 22 2023, 14:55
PiRK updated this revision to Diff 42348.Sep 22 2023, 14:57

remove wrong typehint
In this module the types are defined in arg_types

electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py
673–675

I'm not fixing it in this diff because it is not exactly related, and I'm not sure how to test this, and I'm not sure I want to keep this code around.

PiRK published this revision for review.Sep 22 2023, 14:58
Harbormaster completed remote builds in B25137: Diff 42348.Sep 22 2023, 14:58
PiRK updated this revision to Diff 42360.Sep 25 2023, 06:15

undo function renaming

Harbormaster completed remote builds in B25148: Diff 42360.Sep 25 2023, 06:17
PiRK added a child revision: D14530: [electrum] rename tx_from_str to rawtx_from_str.Sep 25 2023, 06:42
PiRK updated this revision to Diff 42365.Sep 25 2023, 07:15

rebase

Harbormaster completed remote builds in B25152: Diff 42365.Sep 25 2023, 07:17
Fabien accepted this revision.Sep 25 2023, 08:35
This revision is now accepted and ready to land.Sep 25 2023, 08:35
Closed by commit rABC0c195f354aa5: [electrum] store and serialize tx data as bytes (authored by PiRK). · Explain WhySep 25 2023, 12:16
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0c195f354aa5: [electrum] store and serialize tx data as bytes.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
6 lines
4 lines
8 lines
2 lines
tests/
24 lines
54 lines
12 lines
electrumabc_gui/
qt/
10 lines
electrumabc_plugins/
cosigner_pool/
6 lines
digitalbitbox/
9 lines
fusion/
2 lines
keepkey/
tests/
4 lines
ledger/
4 lines
trezor/
tests/
4 lines

Diff 42348

View Options

electrum/electrumabc/commands.py

Loading...
View Options

electrum/electrumabc/network.py

Loading...
View Options

electrum/electrumabc/paymentrequest.py

Loading...
View Options

electrum/electrumabc/synchronizer.py

Loading...
View Options

electrum/electrumabc/tests/test_transaction.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc/wallet.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...
View Options

electrum/electrumabc_plugins/cosigner_pool/qt.py

Loading...
View Options

electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/fusion.py

Loading...
View Options

electrum/electrumabc_plugins/keepkey/tests/test_keepkey.py

Loading...
View Options

electrum/electrumabc_plugins/ledger/ledger.py

Loading...
View Options

electrum/electrumabc_plugins/trezor/tests/test_trezor.py

Loading...