Page MenuHomePhabricator
Differential D1552

[qa] change abandonconflict to explicitly calculate fees
ClosedPublic
Actions

Authored by schancel on Jul 9 2018, 23:01.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING815bd4800dcc: [qa] change abandonconflict to explicitly calculate fees
rABC815bd4800dcc: [qa] change abandonconflict to explicitly calculate fees
Summary

As per title

Test Plan
./test/functional/test_runner.py abandonconflict

Diff Detail

Repository
rABC Bitcoin ABC
Branch
test-fees
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2828
Build 3760: Bitcoin ABC Buildbot (legacy)
Build 3759: arc lint + arc unit

Event Timeline

schancel created this revision.Jul 9 2018, 23:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2018, 23:01
teamcity added a subscriber: teamcity.Jul 9 2018, 23:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added a subscriber: jasonbcox.Jul 9 2018, 23:28
jasonbcox added inline comments.
test/functional/test_framework/util.py
233

Why not just call satoshi_round() instead?

teamcity added a comment.Jul 9 2018, 23:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2828: Diff 4245.Jul 9 2018, 23:44
schancel updated this revision to Diff 4256.Jul 10 2018, 17:02

Minor cleanup

teamcity added a comment.Jul 10 2018, 17:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2018, 17:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2836: Diff 4256!Jul 10 2018, 17:42
schancel updated this revision to Diff 4261.Jul 10 2018, 20:28

rebase to master

teamcity added a comment.Jul 10 2018, 20:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2840: Diff 4261.Jul 10 2018, 21:12
teamcity added a comment.Jul 10 2018, 21:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jul 10 2018, 21:47
This revision is now accepted and ready to land.Jul 10 2018, 21:47
Closed by commit rABC815bd4800dcc: [qa] change abandonconflict to explicitly calculate fees (authored by schancel). · Explain WhyJul 10 2018, 23:45
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
12 lines
test_framework/
6 lines
4 lines

Diff 4245

View Options

test/functional/abandonconflict.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...