Page MenuHomePhabricator
Differential D14572

[avalanche] Remove some useless logs
ClosedPublic
Actions

Authored by Fabien on Oct 2 2023, 14:11.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC91fa3a143daf: [avalanche] Remove some useless logs
Summary

The "Requesting more avalanche addresses [...]" and "Requesting compact proofs [...]" log messages are printed periodically for each peer, which brings zero information and bloats the log. Get rid of them.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Oct 2 2023, 14:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2023, 14:11
Fabien requested review of this revision.Oct 2 2023, 14:11
bytesofman accepted this revision.Oct 2 2023, 14:12
bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
src/net_processing.cpp
1786

unrelated bug fix?

This revision is now accepted and ready to land.Oct 2 2023, 14:12
Fabien added inline comments.Oct 2 2023, 14:16
src/net_processing.cpp
1786

Clearly not a bug fix since it's a comment, but a related comment fix - the summary correctly state that it's sent to all the peers, and the comment mistakenly states it's sent to a single one

Harbormaster completed remote builds in B25226: Diff 42479.Oct 2 2023, 14:28
Closed by commit rABC91fa3a143daf: [avalanche] Remove some useless logs (authored by Fabien). · Explain WhyOct 2 2023, 15:17
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC91fa3a143daf: [avalanche] Remove some useless logs.

Revision Contents
Changeset List

PathSize
src/
8 lines

Diff 42479

View Options

src/net_processing.cpp

Loading...