Page MenuHomePhabricator

[Cashtab] Add test cases for one-to-many xec sends
ClosedPublic

Authored by bytesofman on Oct 2 2023, 16:30.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC7b7220ab9fd3: [Cashtab] Add test cases for one-to-many xec sends
Summary

Depends on D14575

Add unit tests for sendXec on multi-output txs.

Tx raw hex imported to ElectrumABC to verify txid and fee. Note: the p2sh fee is 1.03 sat/byte due to p2sh not being explicitly covered in ecash-coinselect ... the potential available benefit to nailing down p2sh tx sizes is not material for most use cases, probably why it was not done in original coinselect lib

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
send-xec-improvements
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25231
Build 50050: Build Diffcashtab-tests
Build 50049: arc lint + arc unit

Event Timeline

bytesofman updated this revision to Diff 42491.

remove specific vector description

This revision is now accepted and ready to land.Oct 3 2023, 04:43