Page MenuHomePhabricator

[electrum] minor improvements to proof editor
ClosedPublic

Authored by PiRK on Oct 5 2023, 06:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd1649bc29290: [electrum] minor improvements to proof editor
Summary
  • Add a "copy to clipboard" button to Master key fields.
  • Make it visually clear that the master pubkey is not editable (on some systems setReadOnly does not modify the style)
  • Improve tooltips
  • Improve labels
Test Plan

open the proof editor in any wallet

Diff Detail

Repository
rABC Bitcoin ABC
Branch
proof_editor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25276
Build 50138: Build Diffelectrum-tests
Build 50137: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Oct 5 2023, 06:30
Fabien added inline comments.
electrum/electrumabc_gui/qt/avalanche/proof_editor.py
268 ↗(On Diff #42561)

Can we make it unconditionally super duper clear that it's not the coins key? Suggestion:

This key is avalanche specific, unrelated to your coins and cannot be used to spend them. DO NOT USE any existing private key!

make the tooltip more clear and unconditional

This revision is now accepted and ready to land.Oct 5 2023, 09:38
This revision was automatically updated to reflect the committed changes.